Re: RFR: 8339120: Use more fine-granular gcc unused warnings [v6]

2024-08-28 Thread Erik Joelsson
On Wed, 28 Aug 2024 15:17:52 GMT, Magnus Ihse Bursie wrote: >> Currently, we issue -Wno-unused for all files in gcc, which is a rather big >> sledgehammer to get rid of some warnings that proliferate in a few areas of >> the build. >> >> We should instead leave -Wunused turned on (as done by -

Re: RFR: 8339120: Use more fine-granular gcc unused warnings [v6]

2024-08-28 Thread Julian Waters
On Wed, 28 Aug 2024 15:17:52 GMT, Magnus Ihse Bursie wrote: >> Currently, we issue -Wno-unused for all files in gcc, which is a rather big >> sledgehammer to get rid of some warnings that proliferate in a few areas of >> the build. >> >> We should instead leave -Wunused turned on (as done by -

Re: RFR: 8339120: Use more fine-granular gcc unused warnings [v6]

2024-08-28 Thread Kim Barrett
On Wed, 28 Aug 2024 15:15:03 GMT, Magnus Ihse Bursie wrote: >> Currently, we issue -Wno-unused for all files in gcc, which is a rather big >> sledgehammer to get rid of some warnings that proliferate in a few areas of >> the build. >> >> We should instead leave -Wunused turned on (as done by -

Re: RFR: 8339120: Use more fine-granular gcc unused warnings [v6]

2024-08-28 Thread Magnus Ihse Bursie
> Currently, we issue -Wno-unused for all files in gcc, which is a rather big > sledgehammer to get rid of some warnings that proliferate in a few areas of > the build. > > We should instead leave -Wunused turned on (as done by -Wall) and use a much > more fine-grained approach to disabling spe

Re: RFR: 8339120: Use more fine-granular gcc unused warnings [v5]

2024-08-28 Thread Magnus Ihse Bursie
On Wed, 28 Aug 2024 12:29:36 GMT, Magnus Ihse Bursie wrote: >> Good point, I'll try that. > > It turned out to be sort-of okay-ish. I explicitly listed like 6 or so > per-file exclusions in Hotspot (even though my normal cutoff for just setting > a component-wide exclude is 3-4) since it seems

Re: RFR: 8339120: Use more fine-granular gcc unused warnings [v3]

2024-08-28 Thread Magnus Ihse Bursie
On Wed, 28 Aug 2024 13:35:19 GMT, Kim Barrett wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix aarch54 > > make/modules/java.desktop/lib/ClientLibraries.gmk line 284: > >> 282: >> 283: ifeq ($(USE_EXTERN

Re: RFR: 8339120: Use more fine-granular gcc unused warnings [v5]

2024-08-28 Thread Magnus Ihse Bursie
> Currently, we issue -Wno-unused for all files in gcc, which is a rather big > sledgehammer to get rid of some warnings that proliferate in a few areas of > the build. > > We should instead leave -Wunused turned on (as done by -Wall) and use a much > more fine-grained approach to disabling spe

Re: RFR: 8339120: Use more fine-granular gcc unused warnings [v4]

2024-08-28 Thread Magnus Ihse Bursie
> Currently, we issue -Wno-unused for all files in gcc, which is a rather big > sledgehammer to get rid of some warnings that proliferate in a few areas of > the build. > > We should instead leave -Wunused turned on (as done by -Wall) and use a much > more fine-grained approach to disabling spe

Re: RFR: 8339120: Use more fine-granular gcc unused warnings [v3]

2024-08-28 Thread Kim Barrett
On Wed, 28 Aug 2024 13:02:55 GMT, Magnus Ihse Bursie wrote: >> Currently, we issue -Wno-unused for all files in gcc, which is a rather big >> sledgehammer to get rid of some warnings that proliferate in a few areas of >> the build. >> >> We should instead leave -Wunused turned on (as done by -

Re: RFR: 8339120: Use more fine-granular gcc unused warnings [v3]

2024-08-28 Thread Magnus Ihse Bursie
> Currently, we issue -Wno-unused for all files in gcc, which is a rather big > sledgehammer to get rid of some warnings that proliferate in a few areas of > the build. > > We should instead leave -Wunused turned on (as done by -Wall) and use a much > more fine-grained approach to disabling spe

Re: RFR: 8339120: Use more fine-granular gcc unused warnings [v2]

2024-08-28 Thread Magnus Ihse Bursie
On Wed, 28 Aug 2024 11:26:01 GMT, Magnus Ihse Bursie wrote: >> make/autoconf/flags-cflags.m4 line 239: >> >>> 237: # Additional warnings that are not activated by -Wall and -Wextra >>> 238: WARNINGS_ENABLE_ADDITIONAL="-Wpointer-arith -Wreturn-type >>> -Wsign-compare \ >>> 239:

Re: RFR: 8339120: Use more fine-granular gcc unused warnings [v2]

2024-08-28 Thread Magnus Ihse Bursie
> Currently, we issue -Wno-unused for all files in gcc, which is a rather big > sledgehammer to get rid of some warnings that proliferate in a few areas of > the build. > > We should instead leave -Wunused turned on (as done by -Wall) and use a much > more fine-grained approach to disabling spe

Re: RFR: 8339120: Use more fine-granular gcc unused warnings

2024-08-28 Thread Magnus Ihse Bursie
On Wed, 28 Aug 2024 06:38:48 GMT, Kim Barrett wrote: > We should make a similar set of changes for clang, though doing that in a > separate proposal is good. Is there a JBS issue for that yet? Yes, we should. I am 80% done with that patch, but I have not yet opened a JBS ticket. Will do that n

Re: RFR: 8339120: Use more fine-granular gcc unused warnings

2024-08-27 Thread Kim Barrett
On Tue, 27 Aug 2024 20:04:21 GMT, Magnus Ihse Bursie wrote: > Currently, we issue -Wno-unused for all files in gcc, which is a rather big > sledgehammer to get rid of some warnings that proliferate in a few areas of > the build. > > We should instead leave -Wunused turned on (as done by -Wall)

Re: RFR: 8339120: Use more fine-granular gcc unused warnings

2024-08-27 Thread Julian Waters
On Tue, 27 Aug 2024 20:04:21 GMT, Magnus Ihse Bursie wrote: > Currently, we issue -Wno-unused for all files in gcc, which is a rather big > sledgehammer to get rid of some warnings that proliferate in a few areas of > the build. > > We should instead leave -Wunused turned on (as done by -Wall)

RFR: 8339120: Use more fine-granular gcc unused warnings

2024-08-27 Thread Magnus Ihse Bursie
Currently, we issue -Wno-unused for all files in gcc, which is a rather big sledgehammer to get rid of some warnings that proliferate in a few areas of the build. We should instead leave -Wunused turned on (as done by -Wall) and use a much more fine-grained approach to disabling specific warnin

Re: RFR: 8339120: Use more fine-granular gcc unused warnings

2024-08-27 Thread Magnus Ihse Bursie
On Tue, 27 Aug 2024 20:04:21 GMT, Magnus Ihse Bursie wrote: > Currently, we issue -Wno-unused for all files in gcc, which is a rather big > sledgehammer to get rid of some warnings that proliferate in a few areas of > the build. > > We should instead leave -Wunused turned on (as done by -Wall)