On Fri, 30 Aug 2024 22:25:54 GMT, Dean Long wrote:
>> Really, this is better? it adds three parameters. I made this change.
>
> It reduces duplicate code, which is usually good. Yes, I like it better.
Ok!
-
PR Review Comment: https://git.openjdk.org/jdk/pull/20719#discussion_r174
On Mon, 2 Sep 2024 10:30:25 GMT, Amit Kumar wrote:
>> Thanks Chris and Matias for reviewing parts of this.
>
> Hi @coleenp,
>
> I got this error while build on my Mac-M1, did you see something like this ?
> :
>
> ERROR: Failed to generate link optimization data. This is likely a problem
> w
On Fri, 30 Aug 2024 20:11:06 GMT, Coleen Phillimore wrote:
>> Coleen Phillimore has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Fix jvmci code.
>> - Some C2 refactoring.
>> - Assembly corrections from Matias and Dean.
>
> Thanks Ch
On Fri, 30 Aug 2024 21:35:49 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/opto/library_call.cpp line 3777:
>>
>>> 3775: Node* p = basic_plus_adr(kls, in_bytes(Klass::misc_flags_offset()));
>>> 3776: Node* mods = make_load(nullptr, p, TypeInt::UBYTE, T_BOOLEAN,
>>> MemNode::unordered);
On Fri, 30 Aug 2024 20:22:38 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Fix jvmci code.
>> - Some C2 refactoring.
>> - Assembly corrections from Matias and Dean.
>
> src/hotspot/share
On Fri, 30 Aug 2024 14:00:44 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Fri, 30 Aug 2024 14:00:44 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Fri, 30 Aug 2024 14:00:44 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
> Move JVM implementation access flags that are not specified by the classfile
> format into Klass so we can shrink AccessFlags to u2 in a future change.
>
> Tested with tier1-7.
>
> NOTE: there are arm, ppc and s390 changes to this that are just a guess.
> Also, graal changes.
Coleen Phillim
