Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

2024-08-26 Thread Joakim Nordström
On Mon, 26 Aug 2024 13:51:08 GMT, Alan Bateman wrote: >> Reviewing the current implementation this seems to be the case. >> >> The `@implNote` was more meant as an explanation to why the result could be >> affected by other callers. Since the `@apiNote` also states that the >> "observation pe

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

2024-08-26 Thread Alan Bateman
On Mon, 26 Aug 2024 13:46:41 GMT, Joakim Nordström wrote: >> src/jdk.management/share/classes/com/sun/management/OperatingSystemMXBean.java >> line 154: >> >>> 152: * affecting the observation period and the result. >>> 153: * >>> 154: * @implNote There is only one observation p

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

2024-08-26 Thread Joakim Nordström
On Fri, 23 Aug 2024 12:01:43 GMT, Alan Bateman wrote: >> Joakim Nordström has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added implNote and made some re-arrangements > > src/jdk.management/share/classes/com/sun/management/OperatingSyste

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

2024-08-23 Thread Alan Bateman
On Fri, 23 Aug 2024 08:49:38 GMT, Joakim Nordström wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> u

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

2024-08-23 Thread Kevin Walls
On Fri, 23 Aug 2024 08:49:38 GMT, Joakim Nordström wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> u

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

2024-08-23 Thread Joakim Nordström
On Fri, 23 Aug 2024 08:49:38 GMT, Joakim Nordström wrote: >> Can I get a review of this documentation update to clarify the usage of >> GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and >> GetProcessCpuLoad. >> >> Calling either of these methods in quick succession can lead to >> u

Re: RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

2024-08-23 Thread Joakim Nordström
> Can I get a review of this documentation update to clarify the usage of > GetCpuLoad (and inherently deprecated GetSystemCpuLoad) and GetProcessCpuLoad. > > Calling either of these methods in quick succession can lead to > unrepresentative results due to too few data points. > > This behavior