Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands [v2]

2024-11-28 Thread Kevin Walls
On Tue, 26 Nov 2024 21:31:52 GMT, Kevin Walls wrote: >> Remove redundant SecurityManager Permission references >> (following on from JDK-8338411: Implement JEP 486: Permanently Disable the >> Security Manager). > > Kevin Walls has updated the pull request incrementally with one additional > co

Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands [v2]

2024-11-27 Thread Leonid Mesnik
On Tue, 26 Nov 2024 21:31:52 GMT, Kevin Walls wrote: >> Remove redundant SecurityManager Permission references >> (following on from JDK-8338411: Implement JEP 486: Permanently Disable the >> Security Manager). > > Kevin Walls has updated the pull request incrementally with one additional > co

Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands [v2]

2024-11-27 Thread Alan Bateman
On Tue, 26 Nov 2024 21:31:52 GMT, Kevin Walls wrote: >> Remove redundant SecurityManager Permission references >> (following on from JDK-8338411: Implement JEP 486: Permanently Disable the >> Security Manager). > > Kevin Walls has updated the pull request incrementally with one additional > co

Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands

2024-11-27 Thread Kevin Walls
On Sat, 23 Nov 2024 06:37:23 GMT, Alan Bateman wrote: >> Remove redundant SecurityManager Permission references >> (following on from JDK-8338411: Implement JEP 486: Permanently Disable the >> Security Manager). > > This is a change to the spec of a JDK specific API so I think should be > trac

Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands

2024-11-26 Thread Joe Darcy
On Mon, 25 Nov 2024 09:51:10 GMT, Kevin Walls wrote: > > This is a change to the spec of a JDK specific API so I think should be > > tracked by a CSR. > > OK yes, I was looking for opinions on whether this needed a CSR. > > To be clear, the interface jdk.management / > com.sun.management.Diag

Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands [v2]

2024-11-26 Thread Kevin Walls
On Tue, 26 Nov 2024 17:03:22 GMT, Alan Bateman wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove 'cause' > > src/jdk.management/share/classes/com/sun/management/internal/DiagnosticCommandImpl.java > line 112:

Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands [v2]

2024-11-26 Thread Kevin Walls
> Remove redundant SecurityManager Permission references > (following on from JDK-8338411: Implement JEP 486: Permanently Disable the > Security Manager). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Remove 'cause' -

Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands

2024-11-26 Thread Alan Bateman
On Fri, 22 Nov 2024 09:14:30 GMT, Kevin Walls wrote: > Remove redundant SecurityManager Permission references > (following on from JDK-8338411: Implement JEP 486: Permanently Disable the > Security Manager). src/jdk.management/share/classes/com/sun/management/internal/DiagnosticCommandImpl.jav

Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands

2024-11-25 Thread Kevin Walls
On Sat, 23 Nov 2024 06:37:23 GMT, Alan Bateman wrote: > This is a change to the spec of a JDK specific API so I think should be > tracked by a CSR. OK yes, I was looking for opinions on whether this needed a CSR. To be clear, the interface jdk.management / com.sun.management.DiagnosticCommand

Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands

2024-11-23 Thread Alan Bateman
On Fri, 22 Nov 2024 09:14:30 GMT, Kevin Walls wrote: > Remove redundant SecurityManager Permission references > (following on from JDK-8338411: Implement JEP 486: Permanently Disable the > Security Manager). This is a change to the spec of a JDK specific API so I think should be tracked by a

Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands

2024-11-22 Thread Leonid Mesnik
On Fri, 22 Nov 2024 09:14:30 GMT, Kevin Walls wrote: > Remove redundant SecurityManager Permission references > (following on from JDK-8338411: Implement JEP 486: Permanently Disable the > Security Manager). Marked as reviewed by lmesnik (Reviewer). - PR Review: https://git.openj

Re: RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands

2024-11-22 Thread Coleen Phillimore
On Fri, 22 Nov 2024 09:14:30 GMT, Kevin Walls wrote: > Remove redundant SecurityManager Permission references > (following on from JDK-8338411: Implement JEP 486: Permanently Disable the > Security Manager). Looks good! - Marked as reviewed by coleenp (Reviewer). PR Review: http

RFR: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands

2024-11-22 Thread Kevin Walls
Remove redundant SecurityManager Permission references (following on from JDK-8338411: Implement JEP 486: Permanently Disable the Security Manager). - Commit messages: - 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands Changes: https://git.openjd