Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

2024-09-12 Thread Ioi Lam
On Tue, 10 Sep 2024 21:31:31 GMT, Ashutosh Mehra wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @dholmes-ora comments: logging indents > > src/hotspot/share/cds/aotClassLinker.cpp line 149: > >> 147: add_candidate(i

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

2024-09-12 Thread Ashutosh Mehra
On Tue, 10 Sep 2024 22:17:00 GMT, Ashutosh Mehra wrote: > I will continue my review tomorrow. My review is done now. - PR Comment: https://git.openjdk.org/jdk/pull/20843#issuecomment-2346553992

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

2024-09-11 Thread Ioi Lam
On Tue, 10 Sep 2024 10:08:35 GMT, Andrew Dinn wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @dholmes-ora comments: logging indents > > src/hotspot/share/cds/aotClassLinker.hpp line 71: > >> 69: // >> 70: class AOTCla

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

2024-09-10 Thread Ashutosh Mehra
On Tue, 10 Sep 2024 00:53:32 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

2024-09-10 Thread Ashutosh Mehra
On Tue, 10 Sep 2024 00:53:32 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

2024-09-10 Thread Andrew Dinn
On Tue, 10 Sep 2024 00:53:32 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

2024-09-09 Thread David Holmes
On Tue, 10 Sep 2024 00:53:32 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

2024-09-09 Thread Ioi Lam
> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro