On Thu, 4 Apr 2024 12:18:24 GMT, Stefan Karlsson wrote:
>> We have a few places that uses the terms `KlassObj` and `klassOop` when
>> referring to Klasses. This is old code from before the PermGen removal, when
>> Klasses also were Java objects.
>>
>> These names tripped me up when I was readi
On Thu, 4 Apr 2024 12:19:03 GMT, Stefan Karlsson wrote:
>> I'm not even sure what they want to say, really. Should be good to remove,
>> and if anybody can make sense of it, record an issue in the bug-tracker?
>
> OK. I removed the %%%. I'll wait a little bit to see if someone else wants to
> k
On Thu, 4 Apr 2024 12:18:24 GMT, Stefan Karlsson wrote:
>> We have a few places that uses the terms `KlassObj` and `klassOop` when
>> referring to Klasses. This is old code from before the PermGen removal, when
>> Klasses also were Java objects.
>>
>> These names tripped me up when I was readi
On Thu, 4 Apr 2024 12:18:24 GMT, Stefan Karlsson wrote:
>> We have a few places that uses the terms `KlassObj` and `klassOop` when
>> referring to Klasses. This is old code from before the PermGen removal, when
>> Klasses also were Java objects.
>>
>> These names tripped me up when I was readi
On Thu, 4 Apr 2024 12:13:21 GMT, Roman Kennke wrote:
>> I think it is an old-style TODO. I'm considering if we shouldn't just remove
>> these comments. What do people think about that?
>
> I'm not even sure what they want to say, really. Should be good to remove,
> and if anybody can make sense
On Thu, 4 Apr 2024 10:07:11 GMT, Roman Kennke wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review Roman
>
> src/hotspot/share/memory/heapInspection.cpp line 173:
>
>> 171: KlassInfoTable::KlassInfoTable(bool
On Thu, 4 Apr 2024 12:08:23 GMT, Stefan Karlsson wrote:
>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 1202:
>>
>>> 1200: ldrw(scan_temp, Address(recv_klass, Klass::vtable_length_offset()));
>>> 1201:
>>> 1202: // %%% Could store the aligned, prescaled offset in the klassoop.
>>
> We have a few places that uses the terms `KlassObj` and `klassOop` when
> referring to Klasses. This is old code from before the PermGen removal, when
> Klasses also were Java objects.
>
> These names tripped me up when I was reading the heap heapInspection.cpp and
> first though we were mixi
