Re: RFR: 8328592: hprof tests fail with -XX:-CompactStrings [v3]

2024-03-21 Thread Aleksey Shipilev
On Thu, 21 Mar 2024 08:38:34 GMT, Aleksey Shipilev wrote: >> See the bug for symptoms. The tests are failing because hprof test library >> is confused about non-compact strings. >> >> Additional testing: >> - [x] `serviceability/HeapDump lib-test:all` with `-XX:-CompactStrings` now >> pass >>

Re: RFR: 8328592: hprof tests fail with -XX:-CompactStrings [v3]

2024-03-21 Thread Aleksey Shipilev
> See the bug for symptoms. The tests are failing because hprof test library is > confused about non-compact strings. > > Additional testing: > - [x] `serviceability/HeapDump lib-test:all` with `-XX:-CompactStrings` now > pass > - [x] `serviceability/HeapDump lib-test:all` with `-XX:+CompactS

Re: RFR: 8328592: hprof tests fail with -XX:-CompactStrings [v2]

2024-03-20 Thread Paul Hohensee
On Wed, 20 Mar 2024 17:19:34 GMT, Aleksey Shipilev wrote: >> See the bug for symptoms. The tests are failing because hprof test library >> is confused about non-compact strings. >> >> Additional testing: >> - [x] `serviceability/HeapDump lib-test:all` with `-XX:-CompactStrings` now >> pass >>

Re: RFR: 8328592: hprof tests fail with -XX:-CompactStrings [v2]

2024-03-20 Thread Alex Menkov
On Wed, 20 Mar 2024 17:19:34 GMT, Aleksey Shipilev wrote: >> See the bug for symptoms. The tests are failing because hprof test library >> is confused about non-compact strings. >> >> Additional testing: >> - [x] `serviceability/HeapDump lib-test:all` with `-XX:-CompactStrings` now >> pass >>

Re: RFR: 8328592: hprof tests fail with -XX:-CompactStrings [v2]

2024-03-20 Thread Aleksey Shipilev
On Wed, 20 Mar 2024 14:46:09 GMT, Paul Hohensee wrote: > Are we guaranteed that non-compact string char component bytes are stored in > little-endian order? No, I don't think we are guaranteed any particular endianness, argh. The new patch follows what `StringUTF16` does: https://github.com/o

Re: RFR: 8328592: hprof tests fail with -XX:-CompactStrings [v2]

2024-03-20 Thread Aleksey Shipilev
> See the bug for symptoms. The tests are failing because hprof test library is > confused about non-compact strings. > > Additional testing: > - [x] `serviceability/HeapDump lib-test:all` with `-XX:-CompactStrings` now > pass > - [x] `serviceability/HeapDump lib-test:all` with `-XX:+CompactS

Re: RFR: 8328592: hprof tests fail with -XX:-CompactStrings

2024-03-20 Thread Leonid Mesnik
On Wed, 20 Mar 2024 09:53:36 GMT, Aleksey Shipilev wrote: > See the bug for symptoms. The tests are failing because hprof test library is > confused about non-compact strings. > > Additional testing: > - [x] `serviceability/HeapDump lib-test:all` with `-XX:-CompactStrings` now > pass > - [x]

Re: RFR: 8328592: hprof tests fail with -XX:-CompactStrings

2024-03-20 Thread Paul Hohensee
On Wed, 20 Mar 2024 09:53:36 GMT, Aleksey Shipilev wrote: > See the bug for symptoms. The tests are failing because hprof test library is > confused about non-compact strings. > > Additional testing: > - [x] `serviceability/HeapDump lib-test:all` with `-XX:-CompactStrings` now > pass > - [x]

RFR: 8328592: hprof tests fail with -XX:-CompactStrings

2024-03-20 Thread Aleksey Shipilev
See the bug for symptoms. The tests are failing because hprof test library is confused about non-compact strings. Additional testing: - [x] `serviceability/HeapDump lib-test:all` with `-XX:-CompactStrings` now pass - [x] `serviceability/HeapDump lib-test:all` with `-XX:+CompactStrings` still