Re: RFR: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake [v4]

2024-03-20 Thread Leonid Mesnik
On Thu, 21 Mar 2024 01:01:22 GMT, Serguei Spitsyn wrote: >> src/hotspot/share/prims/jvmtiEnv.cpp line 1366: >> >>> 1364: } >>> 1365: >>> 1366: if (java_thread != nullptr) { >> >> I am not sure why this check is needed at this level. It is duplication.The >> GetOwnedMonitorInfoClosure::do_

Re: RFR: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake [v4]

2024-03-20 Thread Serguei Spitsyn
On Wed, 20 Mar 2024 22:41:05 GMT, Leonid Mesnik wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: work around problem for vthreads in >> EscapeBarrier::deoptimize_objects > > src/hotspot/share/prims/jvmti

Re: RFR: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake [v4]

2024-03-20 Thread Leonid Mesnik
On Wed, 20 Mar 2024 22:03:30 GMT, Serguei Spitsyn wrote: >> The `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes were >> introduced in the JDK 22 to unify/simplify the JVM TI functions supporting >> implementation of the virtual threads. This enhancement is to refactor JVM >> TI func

Re: RFR: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake [v4]

2024-03-20 Thread Serguei Spitsyn
> The `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes were > introduced in the JDK 22 to unify/simplify the JVM TI functions supporting > implementation of the virtual threads. This enhancement is to refactor JVM TI > functions `GetOwnedMonitorInfo` and `GetOwnedMonitorStackDepthInfo`