Re: RFR: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake [v2]

2024-03-20 Thread Serguei Spitsyn
On Wed, 20 Mar 2024 15:59:34 GMT, Patricio Chilano Mateo wrote: >> Good suggestion, thanks! >> Would the following fix work ? : >> >> >> git diff >> diff --git a/src/hotspot/share/runtime/escapeBarrier.cpp >> b/src/hotspot/share/runtime/escapeBarrier.cpp >> index bc01d900285..1b6d57644dc 1006

Re: RFR: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake [v2]

2024-03-20 Thread Patricio Chilano Mateo
On Wed, 20 Mar 2024 08:12:06 GMT, Serguei Spitsyn wrote: >> src/hotspot/share/prims/jvmtiEnv.cpp line 1368: >> >>> 1366: if (java_thread != nullptr) { >>> 1367: Handle thread_handle(calling_thread, thread_oop); >>> 1368: EscapeBarrier eb(true, calling_thread, java_thread); >> >> I see

Re: RFR: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake [v2]

2024-03-20 Thread Serguei Spitsyn
On Wed, 20 Mar 2024 02:10:28 GMT, Patricio Chilano Mateo wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: correct one comment > > src/hotspot/share/prims/jvmtiEnv.cpp line 1368: > >> 1366: if (java_th

Re: RFR: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake [v2]

2024-03-19 Thread Patricio Chilano Mateo
On Tue, 19 Mar 2024 00:10:32 GMT, Serguei Spitsyn wrote: >> The `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes were >> introduced in the JDK 22 to unify/simplify the JVM TI functions supporting >> implementation of the virtual threads. This enhancement is to refactor JVM >> TI func

Re: RFR: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake [v2]

2024-03-18 Thread Serguei Spitsyn
> The `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes were > introduced in the JDK 22 to unify/simplify the JVM TI functions supporting > implementation of the virtual threads. This enhancement is to refactor JVM TI > functions `GetOwnedMonitorInfo` and `GetOwnedMonitorStackDepthInfo`