Re: RFR: 8326065: Merge Space into ContiguousSpace

2024-02-23 Thread Albert Mingkun Yang
On Fri, 16 Feb 2024 17:00:15 GMT, Albert Mingkun Yang wrote: > Merging a super class into its single sub class. > > Test: tier1-6 Thanks for review. - PR Comment: https://git.openjdk.org/jdk/pull/17891#issuecomment-1961186277

Re: RFR: 8326065: Merge Space into ContiguousSpace

2024-02-23 Thread Stefan Johansson
On Fri, 16 Feb 2024 17:00:15 GMT, Albert Mingkun Yang wrote: > Merging a super class into its single sub class. > > Test: tier1-6 Looks good, feels like the files should change name as well. Now when there no longer is a `Space`. But maybe that's even better to do once we have moved `TenuredS

Re: RFR: 8326065: Merge Space into ContiguousSpace

2024-02-16 Thread Albert Mingkun Yang
On Fri, 16 Feb 2024 18:48:47 GMT, Chris Plummer wrote: > It looks like the GenerationFactory removal is something that should have > previously been done. True; I overlooked it until the removal of `SpaceClosure` in this PR. - PR Comment: https://git.openjdk.org/jdk/pull/17891#iss

Re: RFR: 8326065: Merge Space into ContiguousSpace

2024-02-16 Thread Chris Plummer
On Fri, 16 Feb 2024 17:00:15 GMT, Albert Mingkun Yang wrote: > Merging a super class into its single sub class. > > Test: tier1-6 The changes look good. It looks like the GenerationFactory removal is something that should have previously been done. Is that the case, or is there something abou

RFR: 8326065: Merge Space into ContiguousSpace

2024-02-16 Thread Albert Mingkun Yang
Merging a super class into its single sub class. Test: tier1-6 - Commit messages: - merge-space Changes: https://git.openjdk.org/jdk/pull/17891/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17891&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326065 Stats: 401 l