On Fri, 16 Feb 2024 12:43:25 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Fri, 16 Feb 2024 12:43:25 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Thu, 15 Feb 2024 17:53:41 GMT, Naoto Sato wrote:
>> `\u000b` is VT (vertical tab)
>> `\u0009` or `\t` perhaps?
>
> Right. `\t` is better to avoid such a mistake.
Ok, fixed.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/17871#discussion_r1492403403
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> changes how it checks files (perhaps due to bug fixes).
>
> I hav
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> chan
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> chan
On Thu, 15 Feb 2024 17:28:52 GMT, Andy Goryachev wrote:
>> Please do not replace those tabs with spaces as they are intentional for
>> testing the runtime to safely ignore them. I suggest replacing them with
>> Unicode escapes (`\u000b`)
>
> `\u000b` is VT (vertical tab)
> `\u0009` or `\t`
On Thu, 15 Feb 2024 17:09:17 GMT, Naoto Sato wrote:
>> All the java/util/Currency tests pass. I also searched the code for "ZZ" but
>> could not find any references in the test.
>
> Please do not replace those tabs with spaces as they are intentional for
> testing the runtime to safely ignore t
On Thu, 15 Feb 2024 15:48:38 GMT, Magnus Ihse Bursie wrote:
>> This looks weird indeed. Luckily it's just test code. Did you run the test
>> after this change?
>
> All the java/util/Currency tests pass. I also searched the code for "ZZ" but
> could not find any references in the test.
Please d
On Thu, 15 Feb 2024 14:01:46 GMT, Erik Joelsson wrote:
>> test/jdk/java/util/Currency/currency.properties line 18:
>>
>>> 16: SB=EUR,111,2, 2099-01-01T00:00:00
>>> 17: US=euR,978,2,2001-01-01T00:00:00
>>> 18: ZZ = ZZZ , 999 , 3
>>
>> This looks weird, but so did t
On Thu, 15 Feb 2024 12:26:11 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> chan
Since jcheck only checks file in a commit, there is a possibility of us getting
files in the repository that would not be accepted by jcheck. This can happen
when extending the set of files checked by jcheck, or if jcheck changes how it
checks files (perhaps due to bug fixes).
I have now run jc
13 matches
Mail list logo
