Re: [jdk23] RFR: 8322812: Manpage for jcmd is missing JFR.view command

2024-07-04 Thread Markus Grönlund
On Thu, 4 Jul 2024 10:51:48 GMT, Erik Gahlin wrote: > 8322812: Manpage for jcmd is missing JFR.view command Marked as reviewed by mgronlun (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/20028#pullrequestreview-2158707721

[jdk23] RFR: 8322812: Manpage for jcmd is missing JFR.view command

2024-07-04 Thread Erik Gahlin
8322812: Manpage for jcmd is missing JFR.view command - Commit messages: - Backport 350f9c1947b0eab3ee233516ceefca1e25de9583 Changes: https://git.openjdk.org/jdk/pull/20028/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20028&range=00 Issue: https://bugs.openjdk.org/brow

Re: RFR: 8322812: Manpage for jcmd is missing JFR.view command [v2]

2024-07-03 Thread Kevin Walls
On Tue, 2 Jul 2024 22:53:45 GMT, Erik Gahlin wrote: >> Could I have a review of a change to the jcmd man page? >> >> Testing: tier1 >> >> Thanks >> Erik > > Erik Gahlin has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove accidentally

Re: RFR: 8322812: Manpage for jcmd is missing JFR.view command [v2]

2024-07-02 Thread Erik Gahlin
> Could I have a review of a change to the jcmd man page? > > Testing: tier1 > > Thanks > Erik Erik Gahlin has updated the pull request incrementally with two additional commits since the last revision: - Remove accidentally added file - Remove fix of typo. It will be handled by JDK-8324089

RFR: 8322812: Manpage for jcmd is missing JFR.view command

2024-07-01 Thread Erik Gahlin
Could I have a review of a change to the jcmd man page? A typo was also fixed for JFR.start. Testing: tier1 Thanks Erik - Commit messages: - Don't touch version - Review feedback - Initial Changes: https://git.openjdk.org/jdk/pull/19942/files Webrev: https://webrevs.openjdk.o

Re: RFR: 8322812: Manpage for jcmd is missing JFR.view command

2024-07-01 Thread Kevin Walls
On Fri, 28 Jun 2024 14:51:57 GMT, Erik Gahlin wrote: > Could I have a review of a change to the jcmd man page? A typo was also fixed > for JFR.start. > > Testing: tier1 > > Thanks > Erik Marked as reviewed by kevinw (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19942

Re: RFR: 8322812: Manpage for jcmd is missing JFR.view command

2024-07-01 Thread Markus Grönlund
On Fri, 28 Jun 2024 14:51:57 GMT, Erik Gahlin wrote: > Could I have a review of a change to the jcmd man page? A typo was also fixed > for JFR.start. > > Testing: tier1 > > Thanks > Erik Marked as reviewed by mgronlun (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/199