Re: RFR: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks [v2]

2023-11-16 Thread David Holmes
On Tue, 14 Nov 2023 08:18:41 GMT, Roman Marchenko wrote: >> Zero'ing memory of extension event callbacks > > Roman Marchenko has updated the pull request incrementally with one > additional commit since the last revision: > > Fixing review comments Also see: https://openjdk.org/guide/index

Re: RFR: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks [v2]

2023-11-15 Thread Daniel D . Daugherty
On Tue, 14 Nov 2023 08:18:41 GMT, Roman Marchenko wrote: >> Zero'ing memory of extension event callbacks > > Roman Marchenko has updated the pull request incrementally with one > additional commit since the last revision: > > Fixing review comments Sure. Here's the relevant sub-section from

Re: RFR: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks [v2]

2023-11-14 Thread Roman Marchenko
On Tue, 14 Nov 2023 20:51:22 GMT, Daniel D. Daugherty wrote: >> Roman Marchenko has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixing review comments > > Just a heads up that HotSpot code normally requires two reviews (1 from a > (R)e

Re: RFR: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks [v2]

2023-11-14 Thread Daniel D . Daugherty
On Tue, 14 Nov 2023 08:18:41 GMT, Roman Marchenko wrote: >> Zero'ing memory of extension event callbacks > > Roman Marchenko has updated the pull request incrementally with one > additional commit since the last revision: > > Fixing review comments Doing a post integration review. This is

Re: RFR: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks [v2]

2023-11-14 Thread Roman Marchenko
On Tue, 14 Nov 2023 08:18:41 GMT, Roman Marchenko wrote: >> Zero'ing memory of extension event callbacks > > Roman Marchenko has updated the pull request incrementally with one > additional commit since the last revision: > > Fixing review comments The previous test run was OK https://githu

Re: RFR: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks [v2]

2023-11-14 Thread Roman Marchenko
On Tue, 14 Nov 2023 07:42:08 GMT, David Holmes wrote: >> Roman Marchenko has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixing review comments > > src/hotspot/share/prims/jvmtiEnvBase.cpp line 217: > >> 215: // all callbacks initiall

Re: RFR: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks [v2]

2023-11-14 Thread Roman Marchenko
> Zero'ing memory of extension event callbacks Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision: Fixing review comments - Changes: - all: https://git.openjdk.org/jdk/pull/16647/files - new: https://git.openjdk.org/j