On Thu, 5 Dec 2024 17:41:00 GMT, Thomas Stuefe wrote:
>>> @tstuefe I ran an experiment with raw mmap, and there's no way to
>>> differentiate between one large allocation of 5*128MB and 5 smaller
>>> allocations of 128MB. I _could_ add code to fold these, but we risk loosing
>>> information.
>
On Thu, 5 Dec 2024 16:04:10 GMT, Thomas Stuefe wrote:
>>> @tstuefe I've look into your test, and I will modify the PR to display
>>> these regions - it was incorrectly identifying them as "free". As to the
>>> strange vmmap behaviour, I found that the two sections appeared in
>>> different pla
On Thu, 5 Dec 2024 16:04:10 GMT, Thomas Stuefe wrote:
>>> @tstuefe I've look into your test, and I will modify the PR to display
>>> these regions - it was incorrectly identifying them as "free". As to the
>>> strange vmmap behaviour, I found that the two sections appeared in
>>> different pla
On Thu, 5 Dec 2024 14:32:53 GMT, Thomas Stuefe wrote:
>> Hi @stooke !
>>
>>> Hello, @tstuefe , and thanks for your comments. I'll address a few here
>>> while I work on the others. I have changed the os-specific names to
>>> lowercase, but I don't think it makes them stand out more. The square
On Thu, 5 Dec 2024 14:32:53 GMT, Thomas Stuefe wrote:
>> Hi @stooke !
>>
>>> Hello, @tstuefe , and thanks for your comments. I'll address a few here
>>> while I work on the others. I have changed the os-specific names to
>>> lowercase, but I don't think it makes them stand out more. The square
On Mon, 2 Dec 2024 14:52:38 GMT, Thomas Stuefe wrote:
>> Hello, @tstuefe , and thanks for your comments. I'll address a few here
>> while I work on the others.
>> I have changed the os-specific names to lowercase, but I don't think it
>> makes them stand out more. The square brackets were int
On Mon, 2 Dec 2024 14:52:38 GMT, Thomas Stuefe wrote:
>> Hello, @tstuefe , and thanks for your comments. I'll address a few here
>> while I work on the others.
>> I have changed the os-specific names to lowercase, but I don't think it
>> makes them stand out more. The square brackets were int
On Thu, 14 Nov 2024 14:13:16 GMT, Simon Tooke wrote:
>> Hi @stooke,
>>
>> nice. There are some aspects about the output that is surprising, though. I
>> expect reserved-only memory to be mapped with MAP_NORESERVE and no access
>> rights. I expect committed memory to be mapped without MAP_NORES
On Mon, 4 Nov 2024 14:04:58 GMT, Thomas Stuefe wrote:
>>> Looking good, small nits remain. Could you share an example output (maybe
>>> one run with G1, one with ZGC?)
>>
>> @tstuefe, Sample output for G1 and ZGC has been attached to the description
>> (and I fixed the ZGC test)
>
> Hi @stooke
On Tue, 29 Oct 2024 14:09:21 GMT, Simon Tooke wrote:
>> Looking good, small nits remain. Could you share an example output (maybe
>> one run with G1, one with ZGC?)
>
>> Looking good, small nits remain. Could you share an example output (maybe
>> one run with G1, one with ZGC?)
>
> @tstuefe, S
On Tue, 29 Oct 2024 08:01:49 GMT, Thomas Stuefe wrote:
> Looking good, small nits remain. Could you share an example output (maybe one
> run with G1, one with ZGC?)
Sample output for G1 and ZGC has been attached to the description (and I fixed
the ZGC test)
-
PR Comment: https://
On Tue, 29 Oct 2024 08:01:13 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes from review
>
> test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTestBase.java line 180:
>
>> 178:
On Tue, 29 Oct 2024 07:59:54 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes from review
>
> src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 212:
>
>> 210: }
>> 211:
>> 212: st-
On Tue, 29 Oct 2024 07:56:42 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes from review
>
> src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 79:
>
>> 77: char buf[PATH_MAX];
>> 78:
On Mon, 28 Oct 2024 14:40:44 GMT, Simon Tooke wrote:
>> This is a port of #16301 to macOS.
>>
>> System.map and System.dump_map are implemented using the macOS API and
>> provide roughly the same information in the same format. Most of the heavy
>> lifting was implemented by @tstuefe in
>> h
On Fri, 25 Oct 2024 15:09:18 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes from review
>
> src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 120:
>
>> 118:
>> 119: static const char*
> This is a port of #16301 to macOS.
>
> System.map and System.dump_map are implemented using the macOS API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in
> https://github.com/openjdk/jdk/pull/16301 - this PR adds the m
17 matches
Mail list logo
