Re: RFR: 8319055: JCMD should not buffer the whole output of commands [v3]

2025-02-06 Thread Alex Menkov
On Tue, 4 Feb 2025 10:10:41 GMT, Johan Sjölen wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback - test > > src/hotspot/share/services/attachListener.cpp line 53: > >> 51: >> 52: // Stream for printing attac

Re: RFR: 8319055: JCMD should not buffer the whole output of commands [v3]

2025-02-06 Thread Alex Menkov
On Wed, 5 Feb 2025 07:24:29 GMT, Thomas Stuefe wrote: >> This is for [JDK-8319307](https://bugs.openjdk.org/browse/JDK-8319307) >> @tstuefe Do you want to keep this comment to work on JDK-8319307? > > You can remove it. Removed - PR Review Comment: https://git.openjdk.org/jdk/pull/

Re: RFR: 8319055: JCMD should not buffer the whole output of commands [v3]

2025-02-06 Thread Alex Menkov
> The fix implements streaming output support for attach protocol. > See JBS issue for evaluation, summary of the changes in the 1st comment. > Testing: tier1..4,hs-tier5-svc Alex Menkov has updated the pull request incrementally with one additional commit since the last revision: feedback - t