Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v8]

2023-11-03 Thread Thomas Schatzl
On Thu, 2 Nov 2023 15:51:35 GMT, Thomas Schatzl wrote: >> The JEP covers the idea very well, so I'm only covering some implementation >> details here: >> >> * regions get a "pin count" (reference count). As long as it is non-zero, we >> conservatively never reclaim that region even if there is

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v8]

2023-11-03 Thread Thomas Schatzl
On Fri, 3 Nov 2023 09:56:43 GMT, Albert Mingkun Yang wrote: >> Thomas Schatzl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add documentation about why and how we handle pinned regions in the >> young/old generation. > > src/hotspot/s

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v8]

2023-11-03 Thread Albert Mingkun Yang
On Thu, 2 Nov 2023 15:52:09 GMT, Thomas Schatzl wrote: >> I (still) do not think it is possible after some more re-testing. There are >> the following situations I can think of: >> >> * string deduplication is a need-to-be-supported case where only the C code >> may have a reference to a pinne

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v8]

2023-11-03 Thread Albert Mingkun Yang
On Thu, 2 Nov 2023 15:51:35 GMT, Thomas Schatzl wrote: >> The JEP covers the idea very well, so I'm only covering some implementation >> details here: >> >> * regions get a "pin count" (reference count). As long as it is non-zero, we >> conservatively never reclaim that region even if there is

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v8]

2023-11-02 Thread Thomas Schatzl
On Mon, 30 Oct 2023 17:12:19 GMT, Thomas Schatzl wrote: >> I do not think so. I will do some more testing about this. > > I (still) do not think it is possible after some more re-testing. There are > the following situations I can think of: > > * string deduplication is a need-to-be-supported c

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v8]

2023-11-02 Thread Thomas Schatzl
> The JEP covers the idea very well, so I'm only covering some implementation > details here: > > * regions get a "pin count" (reference count). As long as it is non-zero, we > conservatively never reclaim that region even if there is no reference in > there. JNI code might have references to i