Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v2]

2023-10-30 Thread Albert Mingkun Yang
On Mon, 30 Oct 2023 13:25:07 GMT, Thomas Schatzl wrote: >> src/hotspot/share/gc/g1/g1EvacFailureRegions.hpp line 36: >> >>> 34: class HeapRegionClaimer; >>> 35: >>> 36: // This class records for every region on the heap whether it has to be >>> retained >> >> I feel the term "retain" has two

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v2]

2023-10-30 Thread Thomas Schatzl
On Sat, 28 Oct 2023 18:32:56 GMT, Albert Mingkun Yang wrote: >> Thomas Schatzl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> ayang review1 > > src/hotspot/share/gc/g1/heapRegion.cpp line 734: > >> 732: // ranges passed in here corre

Re: RFR: 8318706: Implementation of JDK-8276094: JEP 423: Region Pinning for G1 [v2]

2023-10-30 Thread Thomas Schatzl
> The JEP covers the idea very well, so I'm only covering some implementation > details here: > > * regions get a "pin count" (reference count). As long as it is non-zero, we > conservatively never reclaim that region even if there is no reference in > there. JNI code might have references to i