Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818 [v5]

2023-10-19 Thread Chris Plummer
On Thu, 19 Oct 2023 13:52:24 GMT, Hannes Greule wrote: > I think this is worth a backport to jdk21u, what do you think? And if yes, is > it enough to run the backport command on the commit later and create a PR > from it? Since the problem was introduced in 21, that sounds reasonable. You can

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818 [v5]

2023-10-19 Thread Hannes Greule
On Wed, 18 Oct 2023 11:25:19 GMT, Hannes Greule wrote: >> See the bug description for more information. >> >> This implementation brings down the time to take a heap dump on the example >> application in the bug report to <2 seconds on my machine. > > Hannes Greule has updated the pull request

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818 [v5]

2023-10-19 Thread Frederic Parain
On Wed, 18 Oct 2023 11:25:19 GMT, Hannes Greule wrote: >> See the bug description for more information. >> >> This implementation brings down the time to take a heap dump on the example >> application in the bug report to <2 seconds on my machine. > > Hannes Greule has updated the pull request

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818 [v5]

2023-10-18 Thread David Holmes
On Wed, 18 Oct 2023 11:25:19 GMT, Hannes Greule wrote: >> See the bug description for more information. >> >> This implementation brings down the time to take a heap dump on the example >> application in the bug report to <2 seconds on my machine. > > Hannes Greule has updated the pull request

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818 [v5]

2023-10-18 Thread Hannes Greule
> See the bug description for more information. > > This implementation brings down the time to take a heap dump on the example > application in the bug report to <2 seconds on my machine. Hannes Greule has updated the pull request incrementally with one additional commit since the last revisio