On Sat, 5 Aug 2023 16:21:57 GMT, Coleen Phillimore wrote:
>> This patch fixes Wconversion in code in the src/hotspot/share/prims
>> directory. Most of the changes correct the types. jfieldID's are created
>> with the int offset returned by InstanceKlass::field_offset().
>> int field_
On Fri, 4 Aug 2023 23:24:45 GMT, Coleen Phillimore wrote:
> Why not? It's the same and casts the int where it's needed to be an int.
To me the checked_cast looks less ugly in the initialization vs at the uses
sites, but in this case with only one use it doesn't really matter.
-
PR
On Sat, 5 Aug 2023 16:21:57 GMT, Coleen Phillimore wrote:
>> This patch fixes Wconversion in code in the src/hotspot/share/prims
>> directory. Most of the changes correct the types. jfieldID's are created
>> with the int offset returned by InstanceKlass::field_offset().
>> int field_
On Sat, 5 Aug 2023 16:21:57 GMT, Coleen Phillimore wrote:
>> This patch fixes Wconversion in code in the src/hotspot/share/prims
>> directory. Most of the changes correct the types. jfieldID's are created
>> with the int offset returned by InstanceKlass::field_offset().
>> int field_
On Fri, 4 Aug 2023 23:06:54 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/prims/jvm.cpp line 612:
>>
>>> 610: // as implemented in the classic virtual machine; return 0 if object
>>> is null
>>> 611: return handle == nullptr ? 0 :
>>> 612: checked_cast(ObjectSynchronizer::Fast
On Fri, 4 Aug 2023 21:11:05 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Dean's suggested changes.
>
> src/hotspot/share/prims/jni.cpp line 209:
>
>> 207:
>> 208:
>> 209: intptr_t jfieldID
> This patch fixes Wconversion in code in the src/hotspot/share/prims
> directory. Most of the changes correct the types. jfieldID's are created
> with the int offset returned by InstanceKlass::field_offset().
> int field_offset (int index) const { return
> field(index).offset();
