On Thu, 28 Sep 2023 01:57:59 GMT, David Holmes wrote:
>> Please review trivial fix to display class name in the output of "where"
>> command of SA.
>>
>> Testing: hotspot_serviceability
>
> Has the change been tested in the HSDB GUI as requested in the JBS issue?
@dholmes-ora thanks for review
On Wed, 27 Sep 2023 20:45:00 GMT, Ashutosh Mehra wrote:
> Please review trivial fix to display class name in the output of "where"
> command of SA.
>
> Testing: hotspot_serviceability
I believe my github user name has been linked to the OpenJDK user name. So I am
going to try integrate it.
-
On Wed, 27 Sep 2023 20:45:00 GMT, Ashutosh Mehra wrote:
> Please review trivial fix to display class name in the output of "where"
> command of SA.
>
> Testing: hotspot_serviceability
Okay looks reasonable then.
Thanks
-
Marked as reviewed by dholmes (Reviewer).
PR Review: http
On Thu, 28 Sep 2023 01:57:59 GMT, David Holmes wrote:
>> Please review trivial fix to display class name in the output of "where"
>> command of SA.
>>
>> Testing: hotspot_serviceability
>
> Has the change been tested in the HSDB GUI as requested in the JBS issue?
@dholmes-ora thanks for pointi
On Wed, 27 Sep 2023 20:45:00 GMT, Ashutosh Mehra wrote:
> Please review trivial fix to display class name in the output of "where"
> command of SA.
>
> Testing: hotspot_serviceability
Has the change been tested in the HSDB GUI as requested in the JBS issue?
-
PR Comment: https://
On Wed, 27 Sep 2023 23:04:22 GMT, Ashutosh Mehra wrote:
>> Can you add to the CR a copy of the `where` output after this fix? Just a
>> short snippet equivalent to the broken output already in the CR. thanks.
>
> @plummercj for some reason the bot refuses to recognize my committer status
> in j
On Wed, 27 Sep 2023 20:45:00 GMT, Ashutosh Mehra wrote:
> Please review trivial fix to display class name in the output of "where"
> command of SA.
>
> Testing: hotspot_serviceability
https://wiki.openjdk.org/display/SKARA#Skara-AssociatingyourGitHubaccountandyourOpenJDKusername
-
On Wed, 27 Sep 2023 21:07:18 GMT, Chris Plummer wrote:
>> Please review trivial fix to display class name in the output of "where"
>> command of SA.
>>
>> Testing: hotspot_serviceability
>
> Can you add to the CR a copy of the `where` output after this fix? Just a
> short snippet equivalent to
On Wed, 27 Sep 2023 21:07:18 GMT, Chris Plummer wrote:
>> Please review trivial fix to display class name in the output of "where"
>> command of SA.
>>
>> Testing: hotspot_serviceability
>
> Can you add to the CR a copy of the `where` output after this fix? Just a
> short snippet equivalent to
On Wed, 27 Sep 2023 20:45:00 GMT, Ashutosh Mehra wrote:
> Please review trivial fix to display class name in the output of "where"
> command of SA.
>
> Testing: hotspot_serviceability
Looks good. Thanks!
-
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjd
On Wed, 27 Sep 2023 20:45:00 GMT, Ashutosh Mehra wrote:
> Please review trivial fix to display class name in the output of "where"
> command of SA.
>
> Testing: hotspot_serviceability
Updated CR with the output of `where` command after the fix.
-
PR Comment: https://git.openjdk.o
On Wed, 27 Sep 2023 20:45:00 GMT, Ashutosh Mehra wrote:
> Please review trivial fix to display class name in the output of "where"
> command of SA.
>
> Testing: hotspot_serviceability
Can you add to the CR a copy of the `where` output after this fix? Just a short
snippet equivalent to the bro
Please review trivial fix to display class name in the output of "where"
command of SA.
Testing: hotspot_serviceability
-
Commit messages:
- 8313631: SA: stack trace printed using "where" command does not show class
name
Changes: https://git.openjdk.org/jdk/pull/15952/files
Webr
13 matches
Mail list logo
