On Fri, 11 Aug 2023 01:49:57 GMT, Chris Plummer wrote:
> On OSX, don't require that sudo be used to launch SA tools if developer mode
> is enabled. More details are in the CR.
>
> Due to this change, the following tests are no longer being skipped if the
> host has developer mode is enabled.
On Fri, 11 Aug 2023 01:49:57 GMT, Chris Plummer wrote:
> On OSX, don't require that sudo be used to launch SA tools if developer mode
> is enabled. More details are in the CR.
>
> Due to this change, the following tests are no longer being skipped if the
> host has developer mode is enabled.
On Fri, 11 Aug 2023 01:49:57 GMT, Chris Plummer wrote:
> On OSX, don't require that sudo be used to launch SA tools if developer mode
> is enabled. More details are in the CR.
>
> Due to this change, the following tests are no longer being skipped if the
> host has developer mode is enabled.
On Fri, 11 Aug 2023 01:49:57 GMT, Chris Plummer wrote:
> On OSX, don't require that sudo be used to launch SA tools if developer mode
> is enabled. More details are in the CR.
>
> Due to this change, the following tests are no longer being skipped if the
> host has developer mode is enabled.
On Mon, 14 Aug 2023 01:12:54 GMT, David Holmes wrote:
> I would not be worried about trying to deal with a user that changes the
> setting in that way. Test environments are expected to kept in a stable
> condition.
I think it is best to test for developer mode on each test run. The user might
On Mon, 14 Aug 2023 01:14:40 GMT, David Holmes wrote:
> So do we expect developer mode to be enabled in our CI testing?
We don't expect it to be, but it is on a few machines.
-
PR Comment: https://git.openjdk.org/jdk/pull/15238#issuecomment-1676764048
On Fri, 11 Aug 2023 18:00:01 GMT, Chris Plummer wrote:
> but there are only two if developer mode is enabled (developer mode check and
> SA tool launch).
So do we expect developer mode to be enabled in our CI testing?
-
PR Comment: https://git.openjdk.org/jdk/pull/15238#issuecomme
On Fri, 11 Aug 2023 18:00:01 GMT, Chris Plummer wrote:
> I'm not sure about your caching question. I would assume you are asking how
> many times it executed per test, which is only once.
Okay. That is still unfortunate as I would expect this to be a dynamic property
that changes very rarely.
On Fri, 11 Aug 2023 05:52:28 GMT, David Holmes wrote:
> This seems reasonable in principle but I would be concerned about the
> overhead of exec'ing another process here. How many test actually use this?
> Is this query only ever executed per VM lifetime? (otherwise we should cache
> the resul
On Fri, 11 Aug 2023 05:49:45 GMT, David Holmes wrote:
>> On OSX, don't require that sudo be used to launch SA tools if developer mode
>> is enabled. More details are in the CR.
>>
>> Due to this change, the following tests are no longer being skipped if the
>> host has developer mode is enabl
On Fri, 11 Aug 2023 01:49:57 GMT, Chris Plummer wrote:
> On OSX, don't require that sudo be used to launch SA tools if developer mode
> is enabled. More details are in the CR.
>
> Due to this change, the following tests are no longer being skipped if the
> host has developer mode is enabled.
On OSX, don't require that sudo be used to launch SA tools if developer mode is
enabled. More details are in the CR.
Due to this change, the following tests are no longer being skipped if the host
has developer mode is enabled. They previously required running as root because
if sudo was used
12 matches
Mail list logo
