Re: RFR: 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD() [v2]

2023-08-22 Thread Chris Plummer
On Mon, 21 Aug 2023 21:16:02 GMT, Chris Plummer wrote: >> VM.buildLongFromIntsPD() is not longer used. Remove it. > > Chris Plummer has updated the pull request incrementally with two additional > commits since the last revision: > > - update copyright > - Remove debugging code Thanks for th

Re: RFR: 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD() [v2]

2023-08-22 Thread Chris Plummer
On Tue, 22 Aug 2023 08:50:29 GMT, Kevin Walls wrote: > Looks like the SA floatAt is also unused. > So if we don't see a need to maintain a full mirror of > stackValueCollection.cpp then it could be trimmed more. 8-) I think I'll leave it in. The main goal here was to prune some code that was k

Re: RFR: 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD() [v2]

2023-08-22 Thread Kevin Walls
On Mon, 21 Aug 2023 21:16:02 GMT, Chris Plummer wrote: >> VM.buildLongFromIntsPD() is not longer used. Remove it. > > Chris Plummer has updated the pull request incrementally with two additional > commits since the last revision: > > - update copyright > - Remove debugging code Marked as rev

Re: RFR: 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD() [v2]

2023-08-21 Thread Leonid Mesnik
On Mon, 21 Aug 2023 21:10:55 GMT, Chris Plummer wrote: >> VM.buildLongFromIntsPD() is not longer used. Remove it. > > Chris Plummer has updated the pull request incrementally with two additional > commits since the last revision: > > - update copyright > - Remove debugging code Please update

Re: RFR: 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD() [v2]

2023-08-21 Thread Chris Plummer
On Mon, 21 Aug 2023 21:04:47 GMT, Chris Plummer wrote: >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.java line 949: >> >>> 947: >>> 948: public boolean isCompressedOopsEnabled() { >>> 949: //if (compressedOopsEnabled == null) { >> >> I am not sure I understand how t

Re: RFR: 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD() [v2]

2023-08-21 Thread Chris Plummer
On Mon, 21 Aug 2023 20:38:33 GMT, Leonid Mesnik wrote: >> Chris Plummer has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update copyright >> - Remove debugging code > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.jav

Re: RFR: 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD() [v2]

2023-08-21 Thread Chris Plummer
> VM.buildLongFromIntsPD() is not longer used. Remove it. Chris Plummer has updated the pull request incrementally with two additional commits since the last revision: - update copyright - Remove debugging code - Changes: - all: https://git.openjdk.org/jdk/pull/15371/files -