Re: RFR: 8311990: Two JDI tests may interfere with each other [v3]

2024-07-31 Thread David Holmes
On Wed, 31 Jul 2024 19:50:01 GMT, Alex Menkov wrote: >> "Attach fails" scenarios (debuggee starts listening and debugger is expected >> to fail trying to attach) sometimes interfere with other JDI tests (so >> JdwpNetProps.java test or other JDI test or both fail). >> The fix disables the scena

Re: RFR: 8311990: Two JDI tests may interfere with each other [v2]

2024-07-31 Thread Chris Plummer
On Wed, 31 Jul 2024 19:55:54 GMT, Alex Menkov wrote: >> test/jdk/com/sun/jdi/JdwpListenTest.java line 54: >> >>> 52: // It's off by default as it causes test time increase and test >>> interference (see JDK-8231915). >>> 53: private static boolean allowNegativeTesting = >>> 54:

Re: RFR: 8311990: Two JDI tests may interfere with each other [v2]

2024-07-31 Thread Alex Menkov
On Wed, 31 Jul 2024 12:08:33 GMT, David Holmes wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add sys.prop to enable negative testing > > test/jdk/com/sun/jdi/JdwpListenTest.java line 54: > >> 52: // It's off

Re: RFR: 8311990: Two JDI tests may interfere with each other [v3]

2024-07-31 Thread Alex Menkov
> "Attach fails" scenarios (debuggee starts listening and debugger is expected > to fail trying to attach) sometimes interfere with other JDI tests (so > JdwpNetProps.java test or other JDI test or both fail). > The fix disables the scenarios to remove noise in the CI. Alex Menkov has updated th

Re: RFR: 8311990: Two JDI tests may interfere with each other [v2]

2024-07-31 Thread David Holmes
On Tue, 30 Jul 2024 20:11:03 GMT, Alex Menkov wrote: >> "Attach fails" scenarios (debuggee starts listening and debugger is expected >> to fail trying to attach) sometimes interfere with other JDI tests (so >> JdwpNetProps.java test or other JDI test or both fail). >> The fix disables the scena

Re: RFR: 8311990: Two JDI tests may interfere with each other [v2]

2024-07-31 Thread Serguei Spitsyn
On Tue, 30 Jul 2024 20:11:03 GMT, Alex Menkov wrote: >> "Attach fails" scenarios (debuggee starts listening and debugger is expected >> to fail trying to attach) sometimes interfere with other JDI tests (so >> JdwpNetProps.java test or other JDI test or both fail). >> The fix disables the scena

Re: RFR: 8311990: Two JDI tests may interfere with each other [v2]

2024-07-30 Thread Alex Menkov
> "Attach fails" scenarios (debuggee starts listening and debugger is expected > to fail trying to attach) sometimes interfere with other JDI tests (so > JdwpNetProps.java test or other JDI test or both fail). > The fix disables the scenarios to remove noise in the CI. Alex Menkov has updated th

Re: RFR: 8311990: Two JDI tests may interfere with each other

2024-07-29 Thread Alex Menkov
On Mon, 29 Jul 2024 17:25:03 GMT, Chris Plummer wrote: > Was moving the tests to a separate directory and using > `exclusiveAccess.dirs=.` considered? I suppose this test can interfere with many other JDI tests (we have almost 200 in jdk/com/sun/jdi and some in subdirectories) -

Re: RFR: 8311990: Two JDI tests may interfere with each other

2024-07-29 Thread Alex Menkov
On Mon, 29 Jul 2024 00:45:10 GMT, David Holmes wrote: > I'm wondering if this flag should be settable via a property so that you can > enable this testing without having to have a modified repo? Otherwise it is > not clear when/why someone would go to the effort of changing this and doing > th

Re: RFR: 8311990: Two JDI tests may interfere with each other

2024-07-29 Thread Chris Plummer
On Fri, 26 Jul 2024 21:02:32 GMT, Alex Menkov wrote: > "Attach fails" scenarios (debuggee starts listening and debugger is expected > to fail trying to attach) sometimes interfere with other JDI tests (so > JdwpNetProps.java test or other JDI test or both fail). > The fix disables the scenarios

Re: RFR: 8311990: Two JDI tests may interfere with each other

2024-07-28 Thread David Holmes
On Fri, 26 Jul 2024 21:02:32 GMT, Alex Menkov wrote: > "Attach fails" scenarios (debuggee starts listening and debugger is expected > to fail trying to attach) sometimes interfere with other JDI tests (so > JdwpNetProps.java test or other JDI test or both fail). > The fix disables the scenarios

Re: RFR: 8311990: Two JDI tests may interfere with each other

2024-07-27 Thread Serguei Spitsyn
On Fri, 26 Jul 2024 21:02:32 GMT, Alex Menkov wrote: > "Attach fails" scenarios (debuggee starts listening and debugger is expected > to fail trying to attach) sometimes interfere with other JDI tests (so > JdwpNetProps.java test or other JDI test or both fail). > The fix disables the scenarios

RFR: 8311990: Two JDI tests may interfere with each other

2024-07-26 Thread Alex Menkov
"Attach fails" scenarios (debuggee starts listening and debugger is expected to fail trying to attach) sometimes interfere with other JDI tests (so JdwpNetProps.java test or other JDI test or both fail). The fix disables the scenarios to remove noise in the CI. - Commit messages: -