Re: RFR: 8311077: Fix -Wconversion warnings in jvmti code [v2]

2023-06-29 Thread Coleen Phillimore
On Thu, 29 Jun 2023 14:34:06 GMT, Frederic Parain wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fred's comments. > > src/hotspot/share/prims/jvmtiClassFileReconstituter.cpp line 399: > >> 397: int length

Re: RFR: 8311077: Fix -Wconversion warnings in jvmti code [v2]

2023-06-29 Thread Coleen Phillimore
> Please review change for mostly fixing return types in the constant pool and > metadata to fix -Wconversion warnings in JVMTI code. The order of preference > for changes are: 1. change the types to more distinct types (fields in the > constant pool are u2 because that's their size in the clas