On Fri, 29 Sep 2023 02:56:07 GMT, David Holmes wrote:
> > > Hmmm okay - it seems fragile to have a psuedo-destructor in release().
> >
> >
> > I don't know what this comment means.
>
> Object lifetimes should be well managed such that you can't use an object
> after it has been "destroyed". M
On Thu, 28 Sep 2023 11:58:23 GMT, Coleen Phillimore wrote:
> > Hmmm okay - it seems fragile to have a psuedo-destructor in release().
>
> I don't know what this comment means.
Object lifetimes should be well managed such that you can't use an object after
it has been "destroyed". Methods like
On Thu, 28 Sep 2023 01:46:37 GMT, David Holmes wrote:
> Hmmm okay - it seems fragile to have a psuedo-destructor in release().
I don't know what this comment means. It was fragile to *not* have release
destroy the _obj pointer, which was the cause of the original confusion and
problems while
On Tue, 26 Sep 2023 12:47:42 GMT, Coleen Phillimore wrote:
> This change makes WeakHandle and OopHandle release null out the obj pointer,
> at the cost of making the release function non-const and some changes that
> propagated from that. This enables ObjectMonitor code to test for null to
>
On Wed, 27 Sep 2023 12:19:31 GMT, Coleen Phillimore wrote:
> OopHandles and WeakHandles don't have destructors
Hmmm okay - it seems fragile to have a psuedo-destructor in `release()`.
-
PR Comment: https://git.openjdk.org/jdk/pull/15920#issuecomment-1738324423
On Tue, 26 Sep 2023 12:47:42 GMT, Coleen Phillimore wrote:
> This change makes WeakHandle and OopHandle release null out the obj pointer,
> at the cost of making the release function non-const and some changes that
> propagated from that. This enables ObjectMonitor code to test for null to
>
On Tue, 26 Sep 2023 12:47:42 GMT, Coleen Phillimore wrote:
> This change makes WeakHandle and OopHandle release null out the obj pointer,
> at the cost of making the release function non-const and some changes that
> propagated from that. This enables ObjectMonitor code to test for null to
>
On Tue, 26 Sep 2023 12:47:42 GMT, Coleen Phillimore wrote:
> This change makes WeakHandle and OopHandle release null out the obj pointer,
> at the cost of making the release function non-const and some changes that
> propagated from that. This enables ObjectMonitor code to test for null to
>
On Tue, 26 Sep 2023 12:47:42 GMT, Coleen Phillimore wrote:
> This change makes WeakHandle and OopHandle release null out the obj pointer,
> at the cost of making the release function non-const and some changes that
> propagated from that. This enables ObjectMonitor code to test for null to
>
This change makes WeakHandle and OopHandle release null out the obj pointer, at
the cost of making the release function non-const and some changes that
propagated from that. This enables ObjectMonitor code to test for null to see
if the obj was already released, and seems like the right thing t
10 matches
Mail list logo
