On Mon, 22 Jan 2024 08:59:30 GMT, Kim Barrett wrote:
> I don't think `#pragma GCC poison` works for us. It would complain about a
> system or library header that uses NULL and is included after the pragma.
I see, that's a shame in that case
> However, there are still a lot of NULL's left. All
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> Johan Sjölen has updated the pull request incrementally with two additional
> commits since the last revisi
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> Johan Sjölen has updated the pull request incrementally with two additional
> commits since the last revisi
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> Johan Sjölen has updated the pull request incrementally with two additional
> commits since the last revisi
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> Johan Sjölen has updated the pull request incrementally with two additional
> commits since the last revisi
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> Johan Sjölen has updated the pull request incrementally with two additional
> commits since the last revisi
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> Johan Sjölen has updated the pull request incrementally with two additional
> commits since the last revisi
On Thu, 1 Jun 2023 05:23:25 GMT, Tobias Hartmann wrote:
> What's the plan now to prevent re-introducing `NULL`?
Hi Tobias. The only plan in place is social, the reviewers have to look out for
it. I am however researching how to do this through machine. I'm currently
researching ways of prevent
On Tue, 30 May 2023 00:57:40 GMT, David Holmes wrote:
> Can we now poison NULL so it can't get reintroduced? Or would that
> potentially break standard headers?
I'm sure it would. Maybe some changes to Skara?
-
PR Comment: https://git.openjdk.org/jdk/pull/14198#issuecomment-157170
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> Johan Sjölen has updated the pull request incrementally with two additional
> commits since the last revisi
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> Johan Sjölen has updated the pull request incrementally with two additional
> commits since the last revisi
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> Johan Sjölen has updated the pull request incrementally with two additional
> commits since the last revisi
On Mon, 29 May 2023 10:09:15 GMT, Johan Sjölen wrote:
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
> I'd appreciate if this was considered trivial.
Hi, thank you all for the suggestions! I've now applied them. I'll look at
integrating tomorrow.
-
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> Johan Sjölen has updated the pull request incrementally with two additional
> commits since the last revisi
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
> I'd appreciate if this was considered trivial.
Johan Sjölen has updated the pull request incrementally with two additional
commits since the last revision:
- Align
- Suggestions
-
Changes:
- all:
On Mon, 29 May 2023 15:36:36 GMT, Stefan Karlsson wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> src/hotspot/share/gc/z/zHeap.cpp line 438:
>
>> 436:
>> 437: if (addr == zaddress::null) {
>> 438:
On Mon, 29 May 2023 10:17:06 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> src/hotspot/share/runtime/globals.hpp line 632:
>
>> 630:
On Mon, 29 May 2023 10:09:15 GMT, Johan Sjölen wrote:
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
> I'd appreciate if this was considered trivial.
Looks good. A few suggested changes below.
Can we now poison NULL so it can't get reintroduced? Or would that po
On Mon, 29 May 2023 10:09:15 GMT, Johan Sjölen wrote:
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
> I'd appreciate if this was considered trivial.
Looks good. Though, I'd prefer if we could slightly tweak the following two
print lines.
src/hotspot/share/gc/z
On Mon, 29 May 2023 10:09:15 GMT, Johan Sjölen wrote:
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
> I'd appreciate if this was considered trivial.
not a review, but would you like to check if these could replaced as well :-)
./cpu/ppc/macroAssembler_ppc.hpp:
On Mon, 29 May 2023 10:19:02 GMT, Johan Sjölen wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
>> I'd appreciate if this was considered trivial.
>
> src/hotspot/share/utilities/globalDefinitions.cpp line 162:
>
>> 160: static_assert((size_t)HeapWordSize
A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
I'd appreciate if this was considered trivial.
-
Commit messages:
- Fix remaining work
Changes: https://git.openjdk.org/jdk/pull/14198/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14198&range=00
On Mon, 29 May 2023 10:09:15 GMT, Johan Sjölen wrote:
> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes
> I'd appreciate if this was considered trivial.
All of the stuff to actually keep.
src/hotspot/cpu/aarch64/jvmciCodeInstaller_aarch64.cpp line 125:
> 123:
> 1
23 matches
Mail list logo
