Re: RFR: 8308762: Metaspace leak with Instrumentation.retransform [v6]

2023-09-20 Thread Coleen Phillimore
On Thu, 3 Aug 2023 08:43:12 GMT, Jean-Philippe Bempel wrote: >> Fix a small leak in constant pool merging during retransformation of a >> class. If this class has a catch block with `Throwable`, the class >> `Throwable` is pre-resolved in the constant pool, while all the other >> classes are

Re: RFR: 8308762: Metaspace leak with Instrumentation.retransform [v6]

2023-09-20 Thread Jean-Philippe Bempel
On Wed, 20 Sep 2023 00:05:01 GMT, David Holmes wrote: > Is it simply setting metaspace size small enough that the 500 iterations > would exhaust metaspace if there were a leak? yes exactly. with a leak you end up with `OutOfMemoryError: metaspace` running the test - PR Review Co

Re: RFR: 8308762: Metaspace leak with Instrumentation.retransform [v6]

2023-09-19 Thread David Holmes
On Thu, 3 Aug 2023 08:43:12 GMT, Jean-Philippe Bempel wrote: >> Fix a small leak in constant pool merging during retransformation of a >> class. If this class has a catch block with `Throwable`, the class >> `Throwable` is pre-resolved in the constant pool, while all the other >> classes are

Re: RFR: 8308762: Metaspace leak with Instrumentation.retransform [v6]

2023-08-03 Thread Jean-Philippe Bempel
> Fix a small leak in constant pool merging during retransformation of a class. > If this class has a catch block with `Throwable`, the class `Throwable` is > pre-resolved in the constant pool, while all the other classes are in a > unresolved state. So the constant pool merging process was cons