Re: RFR: 8308400: add ForceEarlyReturn support for virtual threads [v5]

2023-05-24 Thread Serguei Spitsyn
On Wed, 24 May 2023 10:27:11 GMT, Serguei Spitsyn wrote: >> This enhancement adds ForceEarlyReturnXXX support for virtual threads. The >> spec defines minimal support that the JVMTI ForceEarlyReturnXXX can be used >> for a virtual thread suspended an an event. >> Actually, the ForceEarlyReturnX

Re: RFR: 8308400: add ForceEarlyReturn support for virtual threads [v5]

2023-05-24 Thread Leonid Mesnik
On Wed, 24 May 2023 10:27:11 GMT, Serguei Spitsyn wrote: >> This enhancement adds ForceEarlyReturnXXX support for virtual threads. The >> spec defines minimal support that the JVMTI ForceEarlyReturnXXX can be used >> for a virtual thread suspended an an event. >> Actually, the ForceEarlyReturnX

Re: RFR: 8308400: add ForceEarlyReturn support for virtual threads [v5]

2023-05-24 Thread Serguei Spitsyn
> This enhancement adds ForceEarlyReturnXXX support for virtual threads. The > spec defines minimal support that the JVMTI ForceEarlyReturnXXX can be used > for a virtual thread suspended an an event. > Actually, the ForceEarlyReturnXXX can supports suspended and mounted virtual > threads. > >

Re: RFR: 8308400: add ForceEarlyReturn support for virtual threads [v4]

2023-05-23 Thread Serguei Spitsyn
> This enhancement adds ForceEarlyReturnXXX support for virtual threads. The > spec defines minimal support that the JVMTI ForceEarlyReturnXXX can be used > for a virtual thread suspended an an event. > Actually, the ForceEarlyReturnXXX can supports suspended and mounted virtual > threads. > >

Re: RFR: 8308400: add ForceEarlyReturn support for virtual threads [v2]

2023-05-23 Thread Serguei Spitsyn
On Sat, 20 May 2023 16:06:31 GMT, Leonid Mesnik wrote: > Although, test is very similar to popframe tests, seems merging code doesn't > give a lot of benefits, Yes. It does not look worth it, as there are also some important differences. We already have similar kinds of duplication in our test

Re: RFR: 8308400: add ForceEarlyReturn support for virtual threads [v3]

2023-05-23 Thread Serguei Spitsyn
> This enhancement adds ForceEarlyReturnXXX support for virtual threads. The > spec defines minimal support that the JVMTI ForceEarlyReturnXXX can be used > for a virtual thread suspended an an event. > Actually, the ForceEarlyReturnXXX can supports suspended and mounted virtual > threads. > >

Re: RFR: 8308400: add ForceEarlyReturn support for virtual threads [v2]

2023-05-22 Thread Serguei Spitsyn
On Sat, 20 May 2023 16:03:20 GMT, Leonid Mesnik wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor tweak in libForceEarlyReturnTest.cpp > > src/hotspot/share/prims/jvmtiEnvBase.cpp line 2078: > >> 2076:

Re: RFR: 8308400: add ForceEarlyReturn support for virtual threads [v2]

2023-05-22 Thread Serguei Spitsyn
On Sat, 20 May 2023 16:00:49 GMT, Leonid Mesnik wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor tweak in libForceEarlyReturnTest.cpp > > src/hotspot/share/prims/jvmtiEnvBase.cpp line 2042: > >> 2040:

Re: RFR: 8308400: add ForceEarlyReturn support for virtual threads [v2]

2023-05-22 Thread Serguei Spitsyn
On Mon, 22 May 2023 09:00:15 GMT, Andrey Turbanov wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor tweak in libForceEarlyReturnTest.cpp > > test/hotspot/jtreg/serviceability/jvmti/vthread/ForceEarlyReturnTe

Re: RFR: 8308400: add ForceEarlyReturn support for virtual threads [v2]

2023-05-22 Thread Andrey Turbanov
On Sat, 20 May 2023 00:21:04 GMT, Serguei Spitsyn wrote: >> This enhancement adds ForceEarlyReturnXXX support for virtual threads. The >> spec defines minimal support that the JVMTI ForceEarlyReturnXXX can be used >> for a virtual thread suspended an an event. >> Actually, the ForceEarlyReturnX

Re: RFR: 8308400: add ForceEarlyReturn support for virtual threads [v2]

2023-05-20 Thread Leonid Mesnik
On Sat, 20 May 2023 00:21:04 GMT, Serguei Spitsyn wrote: >> This enhancement adds ForceEarlyReturnXXX support for virtual threads. The >> spec defines minimal support that the JVMTI ForceEarlyReturnXXX can be used >> for a virtual thread suspended an an event. >> Actually, the ForceEarlyReturnX

Re: RFR: 8308400: add ForceEarlyReturn support for virtual threads [v2]

2023-05-20 Thread Alan Bateman
On Sat, 20 May 2023 00:21:04 GMT, Serguei Spitsyn wrote: >> This enhancement adds ForceEarlyReturnXXX support for virtual threads. The >> spec defines minimal support that the JVMTI ForceEarlyReturnXXX can be used >> for a virtual thread suspended an an event. >> Actually, the ForceEarlyReturnX

Re: RFR: 8308400: add ForceEarlyReturn support for virtual threads [v2]

2023-05-19 Thread Serguei Spitsyn
> This enhancement adds ForceEarlyReturnXXX support for virtual threads. The > spec defines minimal support that the JVMTI ForceEarlyReturnXXX can be used > for a virtual thread suspended an an event. > Actually, the ForceEarlyReturnXXX can supports suspended and mounted virtual > threads. > >

RFR: 8308400: add ForceEarlyReturn support for virtual threads

2023-05-19 Thread Serguei Spitsyn
This enhancement adds ForceEarlyReturnXXX support for virtual threads. The spec defines minimal support that the JVMTI ForceEarlyReturnXXX can be used for a virtual thread suspended an an event. Actually, the ForceEarlyReturnXXX can supports suspended and mounted virtual threads. CSR (approved)