Re: RFR: 8306858: Remove some remnants of CMS from SA agent [v2]

2023-04-27 Thread Thomas Schatzl
On Tue, 25 Apr 2023 16:43:27 GMT, Aleksey Shipilev wrote: >> Thomas Schatzl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> cplummer review > > Looks fine to me. > > But the synopsis has a typo, "remnants". Thanks @shipilev @kimbarrett

Re: RFR: 8306858: Remove some remnants of CMS from SA agent [v2]

2023-04-26 Thread Y . Srinivas Ramakrishna
On Wed, 26 Apr 2023 08:41:30 GMT, Thomas Schatzl wrote: >> Hi all, >> >> please review this change that removes some remaining CMS related stuff. >> >> Testing: tier1-3, gha >> >> Thanks, >> Thomas > > Thomas Schatzl has updated the pull request incrementally with one additional > commit

Re: RFR: 8306858: Remove some remnants of CMS from SA agent [v2]

2023-04-26 Thread Chris Plummer
On Wed, 26 Apr 2023 08:41:30 GMT, Thomas Schatzl wrote: >> Hi all, >> >> please review this change that removes some remaining CMS related stuff. >> >> Testing: tier1-3, gha >> >> Thanks, >> Thomas > > Thomas Schatzl has updated the pull request incrementally with one additional > commit

Re: RFR: 8306858: Remove some remnants of CMS from SA agent [v2]

2023-04-26 Thread Thomas Schatzl
> Hi all, > > please review this change that removes some remaining CMS related stuff. > > Testing: tier1-3, gha > > Thanks, > Thomas Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision: cplummer review - Changes:

Re: RFR: 8306858: Remove some remnants of CMS from SA agent

2023-04-25 Thread Kim Barrett
On Tue, 25 Apr 2023 16:25:40 GMT, Thomas Schatzl wrote: > Hi all, > > please review this change that removes some remaining CMS related stuff. > > Testing: tier1-3, gha > > Thanks, > Thomas Looks good. - Marked as reviewed by kbarrett (Reviewer). PR Review: https://git.open

Re: RFR: 8306858: Remove some remnants of CMS from SA agent

2023-04-25 Thread Chris Plummer
On Tue, 25 Apr 2023 16:25:40 GMT, Thomas Schatzl wrote: > Hi all, > > please review this change that removes some remaining CMS related stuff. > > Testing: tier1-3, gha > > Thanks, > Thomas Marked as reviewed by cjplummer (Reviewer). Copyrights need updating - PR Review: ht