Re: RFR: 8306851: Move Method access flags [v3]

2023-04-28 Thread Coleen Phillimore
On Fri, 28 Apr 2023 18:39:21 GMT, Coleen Phillimore wrote: >> src/hotspot/share/oops/constMethod.cpp line 438: >> >>> 436: } >>> 437: st->cr(); >>> 438: st->print(" - flags: "); _flags.print_on(st); >>>st->cr(); >> >> Method prints its flags as an int and in de

Re: RFR: 8306851: Move Method access flags [v3]

2023-04-28 Thread Coleen Phillimore
On Fri, 28 Apr 2023 18:29:50 GMT, Frederic Parain wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove bool argument from ConstMethodFlags.set function. > > src/hotspot/share/oops/constMethod.cpp line 438: >

Re: RFR: 8306851: Move Method access flags [v3]

2023-04-28 Thread Frederic Parain
On Thu, 27 Apr 2023 14:21:23 GMT, Coleen Phillimore wrote: >> This change moves the flags from AccessFlags to either ConstMethodFlags or >> MethodFlags, depending on whether they are set at class file parse time, >> which makes them essentially const, or at runtime, which makes them needing >>

Re: RFR: 8306851: Move Method access flags [v3]

2023-04-28 Thread Coleen Phillimore
On Fri, 28 Apr 2023 14:18:11 GMT, Matias Saavedra Silva wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove bool argument from ConstMethodFlags.set function. > > src/hotspot/share/oops/method.hpp line 615:

Re: RFR: 8306851: Move Method access flags [v3]

2023-04-28 Thread Matias Saavedra Silva
On Thu, 27 Apr 2023 14:21:23 GMT, Coleen Phillimore wrote: >> This change moves the flags from AccessFlags to either ConstMethodFlags or >> MethodFlags, depending on whether they are set at class file parse time, >> which makes them essentially const, or at runtime, which makes them needing >>

Re: RFR: 8306851: Move Method access flags [v3]

2023-04-28 Thread Doug Simon
On Thu, 27 Apr 2023 14:21:23 GMT, Coleen Phillimore wrote: >> This change moves the flags from AccessFlags to either ConstMethodFlags or >> MethodFlags, depending on whether they are set at class file parse time, >> which makes them essentially const, or at runtime, which makes them needing >>

Re: RFR: 8306851: Move Method access flags [v3]

2023-04-27 Thread David Holmes
On Thu, 27 Apr 2023 14:21:23 GMT, Coleen Phillimore wrote: >> This change moves the flags from AccessFlags to either ConstMethodFlags or >> MethodFlags, depending on whether they are set at class file parse time, >> which makes them essentially const, or at runtime, which makes them needing >>

Re: RFR: 8306851: Move Method access flags [v3]

2023-04-27 Thread Coleen Phillimore
On Thu, 27 Apr 2023 14:21:23 GMT, Coleen Phillimore wrote: >> This change moves the flags from AccessFlags to either ConstMethodFlags or >> MethodFlags, depending on whether they are set at class file parse time, >> which makes them essentially const, or at runtime, which makes them needing >>

Re: RFR: 8306851: Move Method access flags [v3]

2023-04-27 Thread Coleen Phillimore
> This change moves the flags from AccessFlags to either ConstMethodFlags or > MethodFlags, depending on whether they are set at class file parse time, > which makes them essentially const, or at runtime, which makes them needing > atomic access. > > This leaves AccessFlags int size because Kla