Re: RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967 [v3]

2023-04-19 Thread David Holmes
On Wed, 19 Apr 2023 11:09:02 GMT, Markus Grönlund wrote: > It follows the same pattern as for other jvmti*.cpp files also excluded via > make/hotspot/lib/jvmFeatures.gmk. For example, jvmtiExport.cpp. Okay , yes I see that now - I was thrown by the fact that the original versions of these func

Re: RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967 [v3]

2023-04-19 Thread Markus Grönlund
On Wed, 19 Apr 2023 02:22:38 GMT, David Holmes wrote: > @mgronlun I agree this does not look good. I'm not sure this was the right > way to conditionalize the new code, rather than ensuring the callsites were > conditionalized on INCLUDE_JVMTI. It follows the same pattern as for other jvmti*.c

Re: RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967 [v3]

2023-04-18 Thread David Holmes
On Tue, 18 Apr 2023 15:22:02 GMT, Markus Grönlund wrote: >> Greetings, >> >> With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much >> refactoring was done to the JVMTI code concerning agents. However, some >> platforms do not have JVMTI support, and tier5 of testing builds an e

Re: RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967 [v3]

2023-04-18 Thread Ioi Lam
On Tue, 18 Apr 2023 15:22:02 GMT, Markus Grönlund wrote: >> Greetings, >> >> With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much >> refactoring was done to the JVMTI code concerning agents. However, some >> platforms do not have JVMTI support, and tier5 of testing builds an e

Re: RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967 [v3]

2023-04-18 Thread Markus Grönlund
> Greetings, > > With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much > refactoring was done to the JVMTI code concerning agents. However, some > platforms do not have JVMTI support, and tier5 of testing builds an embedded > build, linux-arm32-open-cmp-baseline, which failed b

Re: RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967 [v2]

2023-04-18 Thread Markus Grönlund
> Greetings, > > With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much > refactoring was done to the JVMTI code concerning agents. However, some > platforms do not have JVMTI support, and tier5 of testing builds an embedded > build, linux-arm32-open-cmp-baseline, which failed b

Re: RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967

2023-04-18 Thread Erik Gahlin
On Tue, 18 Apr 2023 14:22:21 GMT, Markus Grönlund wrote: > Greetings, > > With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much > refactoring was done to the JVMTI code concerning agents. However, some > platforms do not have JVMTI support, and tier5 of testing builds an embedd

RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967

2023-04-18 Thread Markus Grönlund
Greetings, With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much refactoring was done to the JVMTI code concerning agents. However, some platforms do not have JVMTI support, and tier5 of testing builds an embedded build, linux-arm32-open-cmp-baseline, which failed because the r