Re: RFR: 8305771: SA ClassWriter.java fails to skip overpass methods

2023-04-26 Thread Ioi Lam
On Wed, 26 Apr 2023 17:43:26 GMT, Kevin Walls wrote: >> Please review this trivial fix. >> >> When checking for bits in `m.getAccessFlags()`, the mask >> `JVM_RECOGNIZED_METHOD_MODIFIERS` should be applied (similar to other uses >> of `m.getAccessFlags()` in ClassWriter.java > > Marked as revi

Re: RFR: 8305771: SA ClassWriter.java fails to skip overpass methods

2023-04-26 Thread Kevin Walls
On Tue, 25 Apr 2023 23:49:56 GMT, Ioi Lam wrote: > Please review this trivial fix. > > When checking for bits in `m.getAccessFlags()`, the mask > `JVM_RECOGNIZED_METHOD_MODIFIERS` should be applied (similar to other uses of > `m.getAccessFlags()` in ClassWriter.java Marked as reviewed by kevi

Re: RFR: 8305771: SA ClassWriter.java fails to skip overpass methods

2023-04-26 Thread Chris Plummer
On Tue, 25 Apr 2023 23:49:56 GMT, Ioi Lam wrote: > Please review this trivial fix. > > When checking for bits in `m.getAccessFlags()`, the mask > `JVM_RECOGNIZED_METHOD_MODIFIERS` should be applied (similar to other uses of > `m.getAccessFlags()` in ClassWriter.java Marked as reviewed by cjpl

Re: RFR: 8305771: SA ClassWriter.java fails to skip overpass methods

2023-04-26 Thread Kevin Walls
On Tue, 25 Apr 2023 23:49:56 GMT, Ioi Lam wrote: > Please review this trivial fix. > > When checking for bits in `m.getAccessFlags()`, the mask > `JVM_RECOGNIZED_METHOD_MODIFIERS` should be applied (similar to other uses of > `m.getAccessFlags()` in ClassWriter.java Looks good to me. Other ex

RFR: 8305771: SA ClassWriter.java fails to skip overpass methods

2023-04-25 Thread Ioi Lam
Please review this trivial fix. When checking for bits in `m.getAccessFlags()`, the mask `JVM_RECOGNIZED_METHOD_MODIFIERS` should be applied (similar to other uses of `m.getAccessFlags()` in ClassWriter.java - Commit messages: - 8305771: SA ClassWriter.java fails to skip overpass