Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-30 Thread Alan Bateman
On Wed, 29 Mar 2023 21:43:38 GMT, Paul Sandoz wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix ThreadSleepEvent again > > src/java.base/share/classes/java/lang/Thread.java line 1546: > >> 1544: // b

Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-30 Thread Alan Bateman
On Thu, 30 Mar 2023 15:29:43 GMT, Serguei Spitsyn wrote: > This becomes obsolete: > `src/hotspot/share/prims/jvmtiTagMap.cpp: // disabled if vritual threads are > enabled with --enable-preview` A left-over from JDK-8285739, thanks, we can remove that comment. - PR Comment: https:/

Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-30 Thread Serguei Spitsyn
On Wed, 29 Mar 2023 08:00:36 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-30 Thread Serguei Spitsyn
On Wed, 29 Mar 2023 08:00:36 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-30 Thread Serguei Spitsyn
On Wed, 29 Mar 2023 08:00:36 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-30 Thread Alan Bateman
On Thu, 30 Mar 2023 14:05:36 GMT, Serguei Spitsyn wrote: > Just wanted to check if we want to bump `@since` version of > `OpaqueFrameException` from 19 to 21. OpaqueFrameException was added as a permanent API in JDK 19 so it doesn't change. - PR Comment: https://git.openjdk.org/j

Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-30 Thread Serguei Spitsyn
On Wed, 29 Mar 2023 08:00:36 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-29 Thread Mandy Chung
On Wed, 29 Mar 2023 08:00:36 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-29 Thread Paul Sandoz
On Wed, 29 Mar 2023 08:00:36 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-29 Thread Paul Sandoz
On Wed, 29 Mar 2023 08:00:36 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-29 Thread Leonid Mesnik
On Wed, 29 Mar 2023 08:00:36 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-29 Thread Chris Plummer
On Wed, 29 Mar 2023 08:00:36 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-29 Thread Alan Bateman
On Wed, 29 Mar 2023 18:30:01 GMT, Chris Plummer wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix ThreadSleepEvent again > > test/hotspot/jtreg/serviceability/jvmti/thread/GetFrameCount/framecnt01/framecnt01.java

Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-29 Thread Chris Plummer
On Wed, 29 Mar 2023 08:00:36 GMT, Alan Bateman wrote: >> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The >> APIs that were preview APIs in Java 19/20 are changed to permanent and their >> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >>

Re: RFR: 8304919: Implementation of Virtual Threads [v4]

2023-03-29 Thread Alan Bateman
> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The > APIs that were preview APIs in Java 19/20 are changed to permanent and their > `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The > JNI and JVMTI versions are bumped as this is the first chan