Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v5]

2023-04-06 Thread Alan Bateman
On Thu, 6 Apr 2023 19:01:39 GMT, Roger Riggs wrote: > Removed. Good, that makes it simpler and it means the qualified export can be removed too. - PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1160162760

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v5]

2023-04-06 Thread Roger Riggs
On Thu, 6 Apr 2023 18:44:02 GMT, Alan Bateman wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert changes to Foreign API to avoid class with another PR >> Rename S390X to S390, representing just the s390 archit

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v5]

2023-04-06 Thread Alan Bateman
On Thu, 6 Apr 2023 17:17:35 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X8

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v5]

2023-04-06 Thread Roger Riggs
> Define an internal jdk.internal.util.Architecture enumeration and static > methods to replace uses of the system property `os.arch`. > The enumeration values are defined to match those used in the build. > The initial values are: `X64, X86, IA64, ARM, AARCH64, RISCV64, S390X, > PPC64LE` > Note