Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-28 Thread Robert Toyonaga
On Fri, 25 Oct 2024 14:32:19 GMT, Thomas Stuefe wrote: >> Robert Toyonaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/hotspot/share/utilities/vmError.cpp >> >> Co-authored-by: David Holmes >> <62092539+dholmes-...@us

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-28 Thread Robert Toyonaga
On Mon, 28 Oct 2024 16:03:32 GMT, Thomas Stuefe wrote: >> Otherwise `make test TEST=hotspot_nmt` throws a lock rank error when running >> the test `location_printing_mmap_1`. That test uses >> `MemTracker::print_containing_region`. > > Thanks. But eew. Okay, ugly but not easy to fix. > Can you

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-28 Thread Thomas Stuefe
On Mon, 28 Oct 2024 15:50:00 GMT, Robert Toyonaga wrote: >> Yes I think so. `MemTracker::print_containing_region` first acquires the >> NMT lock then the `SharedDecoder_lock` like this: >> >> `MemTracker::print_containing_region` --> >> `PrintRegionWalker::do_allocation_site` --> >> `NativeCal

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-28 Thread Robert Toyonaga
On Mon, 28 Oct 2024 15:45:31 GMT, Robert Toyonaga wrote: >> src/hotspot/share/runtime/mutexLocker.cpp line 299: >> >>> 297: MUTEX_DEFN(ThreadsSMRDelete_lock , PaddedMonitor, >>> service-2); // Holds ConcurrentHashTableResize_lock >>> 298: MUTEX_DEFN(ThreadIdTableCreate_lock

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-28 Thread Robert Toyonaga
On Fri, 25 Oct 2024 14:23:29 GMT, Thomas Stuefe wrote: >> Robert Toyonaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/hotspot/share/utilities/vmError.cpp >> >> Co-authored-by: David Holmes >> <62092539+dholmes-...@us

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-25 Thread Thomas Stuefe
On Wed, 2 Oct 2024 13:28:13 GMT, Robert Toyonaga wrote: >> ### Summary >> This PR just replaces `ThreadCritical` with a lock specific to NMT. >> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT. >> I've implemented the new lock with a semaphore so that it can be used e

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-21 Thread Robert Toyonaga
On Sat, 12 Oct 2024 18:42:34 GMT, Afshin Zafari wrote: >> Robert Toyonaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/hotspot/share/utilities/vmError.cpp >> >> Co-authored-by: David Holmes >> <62092539+dholmes-...@us

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-18 Thread Robert Toyonaga
On Sat, 12 Oct 2024 18:42:34 GMT, Afshin Zafari wrote: >> Robert Toyonaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/hotspot/share/utilities/vmError.cpp >> >> Co-authored-by: David Holmes >> <62092539+dholmes-...@us

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-12 Thread Afshin Zafari
On Wed, 2 Oct 2024 13:28:13 GMT, Robert Toyonaga wrote: >> ### Summary >> This PR just replaces `ThreadCritical` with a lock specific to NMT. >> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT. >> I've implemented the new lock with a semaphore so that it can be used e

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-09 Thread Johan Sjölen
On Wed, 2 Oct 2024 13:28:13 GMT, Robert Toyonaga wrote: >> ### Summary >> This PR just replaces `ThreadCritical` with a lock specific to NMT. >> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT. >> I've implemented the new lock with a semaphore so that it can be used e

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-02 Thread David Holmes
On Wed, 2 Oct 2024 13:28:13 GMT, Robert Toyonaga wrote: >> ### Summary >> This PR just replaces `ThreadCritical` with a lock specific to NMT. >> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT. >> I've implemented the new lock with a semaphore so that it can be used e

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-02 Thread Robert Toyonaga
> ### Summary > This PR just replaces `ThreadCritical` with a lock specific to NMT. > `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT. > I've implemented the new lock with a semaphore so that it can be used early > before VM init. There is also the possibility of addi