On Mon, 13 Mar 2023 15:05:04 GMT, Roger Riggs wrote:
>> Daniel Jeliński has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Address review comments
>> - Mention that the returned text is static and thread safe
>> - Define buffer size
>
On Mon, 13 Mar 2023 09:48:19 GMT, Daniel Jeliński wrote:
>> This patch modifies the `getLastErrorString` method to return a `jstring`.
>> Thanks to that we can avoid unnecessary back and forth conversions between
>> Unicode and other charsets on Windows.
>>
>> Other changes include:
>> - the W
On Thu, 9 Mar 2023 18:08:32 GMT, Naoto Sato wrote:
>> Daniel Jeliński has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Address review comments
>> - Mention that the returned text is static and thread safe
>> - Define buffer size
>
>
> This patch modifies the `getLastErrorString` method to return a `jstring`.
> Thanks to that we can avoid unnecessary back and forth conversions between
> Unicode and other charsets on Windows.
>
> Other changes include:
> - the Windows implementation of `getLastErrorString` no longer checks
>
On Fri, 10 Mar 2023 21:47:45 GMT, Roger Riggs wrote:
>> Daniel Jeliński has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Address review comments
>> - Mention that the returned text is static and thread safe
>> - Define buffer size
>
