Re: RFR: 8303527: update for deprecated sprintf for jdk.hotspot.agent [v3]

2023-03-03 Thread Xue-Lei Andrew Fan
On Fri, 3 Mar 2023 18:18:02 GMT, Chris Plummer wrote: > @XueleiFan In the future please get two reviews for all hotspot (and > serviceability) changes. Thanks. Thank you for pointing it out, and the review. - PR: https://git.openjdk.org/jdk/pull/12837

Re: RFR: 8303527: update for deprecated sprintf for jdk.hotspot.agent [v3]

2023-03-03 Thread Chris Plummer
On Fri, 3 Mar 2023 04:19:47 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns. The >> issue was addressed in >> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building >> failu

Re: RFR: 8303527: update for deprecated sprintf for jdk.hotspot.agent [v3]

2023-03-03 Thread Chris Plummer
On Fri, 3 Mar 2023 04:19:47 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns. The >> issue was addressed in >> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building >> failu

Re: RFR: 8303527: update for deprecated sprintf for jdk.hotspot.agent [v3]

2023-03-02 Thread Xue-Lei Andrew Fan
> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns. The issue > was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) > for building failure, and > [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[J

Re: RFR: 8303527: update for deprecated sprintf for jdk.hotspot.agent [v2]

2023-03-02 Thread Chris Plummer
On Thu, 2 Mar 2023 23:13:44 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns. The >> issue was addressed in >> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building >> failu

Re: RFR: 8303527: update for deprecated sprintf for jdk.hotspot.agent [v2]

2023-03-02 Thread Xue-Lei Andrew Fan
On Thu, 2 Mar 2023 19:31:46 GMT, Chris Plummer wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - one more correction >> - correct mistakes > > src/jdk.hotspot.agent/windows/native/libsaproc/sawindbg.cpp line

Re: RFR: 8303527: update for deprecated sprintf for jdk.hotspot.agent [v2]

2023-03-02 Thread Xue-Lei Andrew Fan
> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns. The issue > was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) > for building failure, and > [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[J

Re: RFR: 8303527: update for deprecated sprintf for jdk.hotspot.agent

2023-03-02 Thread Chris Plummer
On Thu, 2 Mar 2023 19:17:40 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns. The issue > was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) > for building failure, and >

RFR: 8303527: update for deprecated sprintf for jdk.hotspot.agent

2023-03-02 Thread Xue-Lei Andrew Fan
Hi, May I have this update reviewed? The sprintf is deprecated in Xcode 14 because of security concerns. The issue was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building failure, and [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[JDK-8299635](http