> While working on [JDK-8289765](https://bugs.openjdk.org/browse/JDK-8289765),
> I ended up doing a lot of cleanup of nsk/share/jdi/EventHandler.java, so much
> so that the changes distract from the actual bug fix, so I decided it would
> be best to first push them with a separate CR. Changes in
On Wed, 1 Mar 2023 21:35:34 GMT, Chris Plummer wrote:
>> Well, I am not going to insist.
>
> The following doc (and I have no idea how "official" it is since it is 25
> years old):
>
> https://www.oracle.com/technetwork/java/codeconventions-150003.pdf
>
> Says to indent the 2nd and 3rd lines b
On Wed, 1 Mar 2023 21:12:20 GMT, Leonid Mesnik wrote:
>> I find that much less readable since the 2nd and 3rd lines of the `if`
>> expression are indented the same as the first statement that follows.
>> Previously they had added a blank line to resolve this, but I don't like
>> that either. Y
On Wed, 1 Mar 2023 21:02:50 GMT, Chris Plummer wrote:
>> Just as it was before.
>> if (event instanceof ExceptionEvent &&
>> defaultExceptionRequest != null &&
>> defaultExceptionRequest.equals(event.request())) {
>
> I find that much less readable since the 2nd and 3rd lines of the `
On Wed, 15 Feb 2023 00:13:22 GMT, Chris Plummer wrote:
> While working on [JDK-8289765](https://bugs.openjdk.org/browse/JDK-8289765),
> I ended up doing a lot of cleanup of nsk/share/jdi/EventHandler.java, so much
> so that the changes distract from the actual bug fix, so I decided it would
>
On Wed, 1 Mar 2023 20:57:24 GMT, Leonid Mesnik wrote:
>> How would you recommend doing it? Is there a style guide that covers this (I
>> can never find it when I need it).
>
> Just as it was before.
> if (event instanceof ExceptionEvent &&
> defaultExceptionRequest != null &&
> defau
On Wed, 1 Mar 2023 19:48:36 GMT, Chris Plummer wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/share/jdi/EventHandler.java line 336:
>>
>>> 334: defaultExceptionRequest != null &&
>>> 335: defaultExceptionRequest.equals(event.request()))
>>> 336:
On Wed, 1 Mar 2023 15:59:57 GMT, Leonid Mesnik wrote:
>> While working on [JDK-8289765](https://bugs.openjdk.org/browse/JDK-8289765),
>> I ended up doing a lot of cleanup of nsk/share/jdi/EventHandler.java, so
>> much so that the changes distract from the actual bug fix, so I decided it
>> wou
On Wed, 15 Feb 2023 00:13:22 GMT, Chris Plummer wrote:
> While working on [JDK-8289765](https://bugs.openjdk.org/browse/JDK-8289765),
> I ended up doing a lot of cleanup of nsk/share/jdi/EventHandler.java, so much
> so that the changes distract from the actual bug fix, so I decided it would
>
On Wed, 15 Feb 2023 00:13:22 GMT, Chris Plummer wrote:
> While working on [JDK-8289765](https://bugs.openjdk.org/browse/JDK-8289765),
> I ended up doing a lot of cleanup of nsk/share/jdi/EventHandler.java, so much
> so that the changes distract from the actual bug fix, so I decided it would
>
On Wed, 15 Feb 2023 00:13:22 GMT, Chris Plummer wrote:
> While working on [JDK-8289765](https://bugs.openjdk.org/browse/JDK-8289765),
> I ended up doing a lot of cleanup of nsk/share/jdi/EventHandler.java, so much
> so that the changes distract from the actual bug fix, so I decided it would
>
On Wed, 15 Feb 2023 00:13:22 GMT, Chris Plummer wrote:
> While working on [JDK-8289765](https://bugs.openjdk.org/browse/JDK-8289765),
> I ended up doing a lot of cleanup of nsk/share/jdi/EventHandler.java, so much
> so that the changes distract from the actual bug fix, so I decided it would
>
While working on [JDK-8289765](https://bugs.openjdk.org/browse/JDK-8289765), I
ended up doing a lot of cleanup of nsk/share/jdi/EventHandler.java, so much so
that the changes distract from the actual bug fix, so I decided it would be
best to first push them with a separate CR. Changes include:
13 matches
Mail list logo