Re: RFR: 8299635: More test issues for deprecated sprintf in Xcode 14 [v5]

2023-01-14 Thread Xue-Lei Andrew Fan
> The sprintf is deprecated in Xcode 14 because of security concerns. The issue > was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) > for hotspot impl, and > [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378) for building, but > the test case was not covered. T

Re: RFR: 8299635: More test issues for deprecated sprintf in Xcode 14

2023-01-14 Thread Xue-Lei Andrew Fan
On Fri, 13 Jan 2023 01:56:23 GMT, Serguei Spitsyn wrote: > There are more uses of sprintf in some serviceability folders: Yes. There are at least 57 src files that use sprintf function, as far as I can see. This PR is pretty big now. I would like to clean them up in an other PR so that it i

Re: RFR: 8299635: More test issues for deprecated sprintf in Xcode 14 [v4]

2023-01-13 Thread Xue-Lei Andrew Fan
> The sprintf is deprecated in Xcode 14 because of security concerns. The issue > was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) > for hotspot impl, and > [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378) for building, but > the test case was not covered. T

Re: RFR: 8299635: More test issues for deprecated sprintf in Xcode 14 [v3]

2023-01-13 Thread Xue-Lei Andrew Fan
> The sprintf is deprecated in Xcode 14 because of security concerns. The issue > was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) > for hotspot impl, and > [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378) for building, but > the test case was not covered. T

Re: RFR: 8299635: More test issues for deprecated sprintf in Xcode 14 [v2]

2023-01-13 Thread Mikael Vidstedt
On Fri, 13 Jan 2023 23:27:36 GMT, Xue-Lei Andrew Fan wrote: >> The sprintf is deprecated in Xcode 14 because of security concerns. The >> issue was addressed in >> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for hotspot impl, >> and [JDK-8299378](https://bugs.openjdk.org/browse/

Re: RFR: 8299635: More test issues for deprecated sprintf in Xcode 14 [v2]

2023-01-13 Thread Xue-Lei Andrew Fan
> The sprintf is deprecated in Xcode 14 because of security concerns. The issue > was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) > for hotspot impl, and > [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378) for building, but > the test case was not covered. T

Re: RFR: 8299635: More test issues for deprecated sprintf in Xcode 14

2023-01-13 Thread Xue-Lei Andrew Fan
On Thu, 12 Jan 2023 07:25:07 GMT, Xue-Lei Andrew Fan wrote: >>> This PR does not address all the remaining sprintf:s in hotspot, and with >>> it now explicitly forbidden the build will fail: >>> >> >> This is a question to me as well. I noticed there are still some use of >> sprintf, but the

Re: RFR: 8299635: More test issues for deprecated sprintf in Xcode 14

2023-01-13 Thread Serguei Spitsyn
On Wed, 11 Jan 2023 06:26:18 GMT, Xue-Lei Andrew Fan wrote: > The sprintf is deprecated in Xcode 14 because of security concerns. The issue > was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) > for hotspot impl, and > [JDK-8299378](https://bugs.openjdk.org/browse/JDK-

Re: RFR: 8299635: More test issues for deprecated sprintf in Xcode 14

2023-01-13 Thread Serguei Spitsyn
On Thu, 12 Jan 2023 07:25:07 GMT, Xue-Lei Andrew Fan wrote: >>> This PR does not address all the remaining sprintf:s in hotspot, and with >>> it now explicitly forbidden the build will fail: >>> >> >> This is a question to me as well. I noticed there are still some use of >> sprintf, but the

Re: RFR: 8299635: More test issues for deprecated sprintf in Xcode 14

2023-01-12 Thread Serguei Spitsyn
On Wed, 11 Jan 2023 06:26:18 GMT, Xue-Lei Andrew Fan wrote: > The sprintf is deprecated in Xcode 14 because of security concerns. The issue > was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) > for hotspot impl, and > [JDK-8299378](https://bugs.openjdk.org/browse/JDK-

Re: RFR: 8299635: More test issues for deprecated sprintf in Xcode 14

2023-01-11 Thread Xue-Lei Andrew Fan
On Wed, 11 Jan 2023 21:29:01 GMT, Xue-Lei Andrew Fan wrote: > > I'm also curious: some of the sprintfs are C2 (src/hotspot/share/opto) - > > are your builds including C2? If so, why are you not running into the issue > > for those files? > > I'm new to hotspot. Do you know how could I enable C

Re: RFR: 8299635: More test issues for deprecated sprintf in Xcode 14

2023-01-11 Thread Xue-Lei Andrew Fan
On Wed, 11 Jan 2023 21:16:51 GMT, Mikael Vidstedt wrote: > This PR does not address all the remaining sprintf:s in hotspot, and with it > now explicitly forbidden the build will fail: > This is a question to me as well. I noticed there are still some use of sprintf, but the building passed o

Re: RFR: 8299635: More test issues for deprecated sprintf in Xcode 14

2023-01-11 Thread Mikael Vidstedt
On Wed, 11 Jan 2023 06:26:18 GMT, Xue-Lei Andrew Fan wrote: > The sprintf is deprecated in Xcode 14 because of security concerns. The issue > was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) > for hotspot impl, and > [JDK-8299378](https://bugs.openjdk.org/browse/JDK-

RFR: 8299635: More test issues for deprecated sprintf in Xcode 14

2023-01-11 Thread Xue-Lei Andrew Fan
The sprintf is deprecated in Xcode 14 because of security concerns. The issue was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for hotspot impl, and [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378) for building, but the test case was not covered. The failure