Re: RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v4]

2023-01-09 Thread Andrey Turbanov
On Mon, 9 Jan 2023 03:29:04 GMT, Yi Yang wrote: >> harmless refactor to share code across different platforms of >> VirtualMachineImpl: >> 1. Shared code to process command response after requesting a command >> execution >> 2. Read functionality in SocketInputStream can be reused > > Yi Yang h

Re: RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v4]

2023-01-08 Thread Yi Yang
On Thu, 5 Jan 2023 04:28:46 GMT, David Holmes wrote: > I was thinking more about describing what the parameters are - in particular > it is unclear why the actual IOE can be replaced by a passed in one. If we > wanted a custom message then I would at least expect to chain the actual IOE > to t

Re: RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v4]

2023-01-08 Thread Yi Yang
> harmless refactor to share code across different platforms of > VirtualMachineImpl: > 1. Shared code to process command response after requesting a command > execution > 2. Read functionality in SocketInputStream can be reused Yi Yang has updated the pull request incrementally with two additio