On Fri, 17 Feb 2023 17:33:19 GMT, Kevin Walls wrote:
>> Alexey Bakhtin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimize ObjectName.matchDomains
>
> Yes, I think it looks good.
> I looked a while ago but it was somewhat unfamiliar
On Fri, 17 Feb 2023 17:33:19 GMT, Kevin Walls wrote:
>> Alexey Bakhtin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimize ObjectName.matchDomains
>
> Yes, I think it looks good.
> I looked a while ago but it was somewhat unfamiliar
On Fri, 17 Feb 2023 18:20:32 GMT, Alexey Bakhtin wrote:
>> src/java.management/share/classes/javax/management/ObjectName.java line 2026:
>>
>>> 2024: // This ObjectName is the pattern
>>> 2025: // The other ObjectName is the string.
>>> 2026: if (useOptimized)
On Fri, 17 Feb 2023 17:34:53 GMT, Kevin Walls wrote:
> 2026 and 2031 I was referring to with the nit about if and { }
Hi @kevinjwalls ! Thank you for review.
The braces are added
-
PR: https://git.openjdk.org/jdk/pull/11758
On Thu, 16 Feb 2023 08:16:40 GMT, Serguei Spitsyn wrote:
> Hi Alexey, I hope, Kevin will have a chance to review your PR. I'll check
> with him.
Thank you!
-
PR: https://git.openjdk.org/jdk/pull/11758
On Thu, 2 Feb 2023 13:42:51 GMT, Alexey Bakhtin wrote:
>> Please find a patch to improve JMX Repository.query performance
>>
>> Using ObjectName.apply() allows significantly decrease memory usage and the
>> number of GC cycles:
>> Before:
>>
>> $ java test 100 100
>> Test PASSED in 894
On Thu, 2 Feb 2023 13:42:51 GMT, Alexey Bakhtin wrote:
>> Please find a patch to improve JMX Repository.query performance
>>
>> Using ObjectName.apply() allows significantly decrease memory usage and the
>> number of GC cycles:
>> Before:
>>
>> $ java test 100 100
>> Test PASSED in 894
On Thu, 2 Feb 2023 13:42:51 GMT, Alexey Bakhtin wrote:
>> Please find a patch to improve JMX Repository.query performance
>>
>> Using ObjectName.apply() allows significantly decrease memory usage and the
>> number of GC cycles:
>> Before:
>>
>> $ java test 100 100
>> Test PASSED in 894
> Please find a patch to improve JMX Repository.query performance
>
> Using ObjectName.apply() allows significantly decrease memory usage and the
> number of GC cycles:
> Before:
>
> $ java test 100 100
> Test PASSED in 8943169791 ns.
> GC: G1 Young Generation getCollectionCount()=177 ge
