Re: RFR: 8299234: JMX Repository.query performance [v6]

2023-02-20 Thread Daniel Fuchs
On Fri, 17 Feb 2023 18:25:10 GMT, Alexey Bakhtin wrote: >> Please find a patch to improve JMX Repository.query performance >> >> Using ObjectName.apply() allows significantly decrease memory usage and the >> number of GC cycles: >> Before: >> >> $ java test 100 100 >> Test PASSED in 89

Re: RFR: 8299234: JMX Repository.query performance [v5]

2023-02-20 Thread Serguei Spitsyn
On Fri, 17 Feb 2023 17:33:19 GMT, Kevin Walls wrote: >> Alexey Bakhtin has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Optimize ObjectName.matchDomains > > Yes, I think it looks good. > I looked a while ago but it was somewhat unfamiliar

Re: RFR: 8299234: JMX Repository.query performance [v5]

2023-02-20 Thread Alexey Bakhtin
On Fri, 17 Feb 2023 17:33:19 GMT, Kevin Walls wrote: >> Alexey Bakhtin has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Optimize ObjectName.matchDomains > > Yes, I think it looks good. > I looked a while ago but it was somewhat unfamiliar

Re: RFR: 8299234: JMX Repository.query performance [v6]

2023-02-17 Thread Kevin Walls
On Fri, 17 Feb 2023 18:25:10 GMT, Alexey Bakhtin wrote: >> Please find a patch to improve JMX Repository.query performance >> >> Using ObjectName.apply() allows significantly decrease memory usage and the >> number of GC cycles: >> Before: >> >> $ java test 100 100 >> Test PASSED in 89

Re: RFR: 8299234: JMX Repository.query performance [v5]

2023-02-17 Thread Kevin Walls
On Fri, 17 Feb 2023 18:20:32 GMT, Alexey Bakhtin wrote: >> src/java.management/share/classes/javax/management/ObjectName.java line 2026: >> >>> 2024: // This ObjectName is the pattern >>> 2025: // The other ObjectName is the string. >>> 2026: if (useOptimized)

Re: RFR: 8299234: JMX Repository.query performance [v6]

2023-02-17 Thread Alexey Bakhtin
> Please find a patch to improve JMX Repository.query performance > > Using ObjectName.apply() allows significantly decrease memory usage and the > number of GC cycles: > Before: > > $ java test 100 100 > Test PASSED in 8943169791 ns. > GC: G1 Young Generation getCollectionCount()=177 ge

Re: RFR: 8299234: JMX Repository.query performance [v5]

2023-02-17 Thread Alexey Bakhtin
On Fri, 17 Feb 2023 17:34:53 GMT, Kevin Walls wrote: > 2026 and 2031 I was referring to with the nit about if and { } Hi @kevinjwalls ! Thank you for review. The braces are added - PR: https://git.openjdk.org/jdk/pull/11758

Re: RFR: 8299234: JMX Repository.query performance [v5]

2023-02-16 Thread Alexey Bakhtin
On Thu, 16 Feb 2023 08:16:40 GMT, Serguei Spitsyn wrote: > Hi Alexey, I hope, Kevin will have a chance to review your PR. I'll check > with him. Thank you! - PR: https://git.openjdk.org/jdk/pull/11758

Re: RFR: 8299234: JMX Repository.query performance [v5]

2023-02-16 Thread Serguei Spitsyn
On Thu, 2 Feb 2023 13:42:51 GMT, Alexey Bakhtin wrote: >> Please find a patch to improve JMX Repository.query performance >> >> Using ObjectName.apply() allows significantly decrease memory usage and the >> number of GC cycles: >> Before: >> >> $ java test 100 100 >> Test PASSED in 894

Re: RFR: 8299234: JMX Repository.query performance [v5]

2023-02-15 Thread Alexey Bakhtin
On Thu, 2 Feb 2023 13:42:51 GMT, Alexey Bakhtin wrote: >> Please find a patch to improve JMX Repository.query performance >> >> Using ObjectName.apply() allows significantly decrease memory usage and the >> number of GC cycles: >> Before: >> >> $ java test 100 100 >> Test PASSED in 894

Re: RFR: 8299234: JMX Repository.query performance [v5]

2023-02-13 Thread Alexey Bakhtin
On Thu, 2 Feb 2023 13:42:51 GMT, Alexey Bakhtin wrote: >> Please find a patch to improve JMX Repository.query performance >> >> Using ObjectName.apply() allows significantly decrease memory usage and the >> number of GC cycles: >> Before: >> >> $ java test 100 100 >> Test PASSED in 894

Re: RFR: 8299234: JMX Repository.query performance [v3]

2023-02-02 Thread Alexey Bakhtin
On Mon, 23 Jan 2023 14:14:50 GMT, Daniel Fuchs wrote: >> Alexey Bakhtin has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix parameters order for Util.wildmatch > > Hi Alexey - you have addressed most of my concerns but let me reinstate t

Re: RFR: 8299234: JMX Repository.query performance [v5]

2023-02-02 Thread Alexey Bakhtin
> Please find a patch to improve JMX Repository.query performance > > Using ObjectName.apply() allows significantly decrease memory usage and the > number of GC cycles: > Before: > > $ java test 100 100 > Test PASSED in 8943169791 ns. > GC: G1 Young Generation getCollectionCount()=177 ge

Re: RFR: 8299234: JMX Repository.query performance [v4]

2023-01-30 Thread Daniel Fuchs
On Mon, 23 Jan 2023 20:25:17 GMT, Alexey Bakhtin wrote: >> Please find a patch to improve JMX Repository.query performance >> >> Using ObjectName.apply() allows significantly decrease memory usage and the >> number of GC cycles: >> Before: >> >> $ java test 100 100 >> Test PASSED in 89

Re: RFR: 8299234: JMX Repository.query performance [v3]

2023-01-23 Thread Alexey Bakhtin
On Wed, 11 Jan 2023 14:09:21 GMT, Alexey Bakhtin wrote: >> Please find a patch to improve JMX Repository.query performance >> >> Using ObjectName.apply() allows significantly decrease memory usage and the >> number of GC cycles: >> Before: >> >> $ java test 100 100 >> Test PASSED in 89

Re: RFR: 8299234: JMX Repository.query performance [v4]

2023-01-23 Thread Alexey Bakhtin
> Please find a patch to improve JMX Repository.query performance > > Using ObjectName.apply() allows significantly decrease memory usage and the > number of GC cycles: > Before: > > $ java test 100 100 > Test PASSED in 8943169791 ns. > GC: G1 Young Generation getCollectionCount()=177 ge

Re: RFR: 8299234: JMX Repository.query performance [v3]

2023-01-23 Thread Daniel Fuchs
On Wed, 11 Jan 2023 14:09:21 GMT, Alexey Bakhtin wrote: >> Please find a patch to improve JMX Repository.query performance >> >> Using ObjectName.apply() allows significantly decrease memory usage and the >> number of GC cycles: >> Before: >> >> $ java test 100 100 >> Test PASSED in 89

Re: RFR: 8299234: JMX Repository.query performance [v2]

2023-01-11 Thread Alexey Bakhtin
On Wed, 11 Jan 2023 12:02:57 GMT, Daniel Fuchs wrote: >> Alexey Bakhtin has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use copy of the ObjectName for matching > > src/java.management/share/classes/javax/management/ObjectName.java line 2

Re: RFR: 8299234: JMX Repository.query performance [v3]

2023-01-11 Thread Alexey Bakhtin
> Please find a patch to improve JMX Repository.query performance > > Using ObjectName.apply() allows significantly decrease memory usage and the > number of GC cycles: > Before: > > $ java test 100 100 > Test PASSED in 8943169791 ns. > GC: G1 Young Generation getCollectionCount()=177 ge

Re: RFR: 8299234: JMX Repository.query performance [v2]

2023-01-11 Thread Daniel Fuchs
On Wed, 11 Jan 2023 11:29:39 GMT, Alexey Bakhtin wrote: >> Please find a patch to improve JMX Repository.query performance >> >> Using ObjectName.apply() allows significantly decrease memory usage and the >> number of GC cycles: >> Before: >> >> $ java test 100 100 >> Test PASSED in 89

Re: RFR: 8299234: JMX Repository.query performance

2023-01-11 Thread Alexey Bakhtin
On Tue, 10 Jan 2023 17:14:29 GMT, Daniel Fuchs wrote: > I see several issues with the proposed changes: ObjectName is not final, so > I'm not sure the changes proposed to ObjectName are safe when/if a subclass > is supplied. And in addition, because it's not final, you will need to make a > de

Re: RFR: 8299234: JMX Repository.query performance [v2]

2023-01-11 Thread Alexey Bakhtin
> Please find a patch to improve JMX Repository.query performance > > Using ObjectName.apply() allows significantly decrease memory usage and the > number of GC cycles: > Before: > > $ java test 100 100 > Test PASSED in 8943169791 ns. > GC: G1 Young Generation getCollectionCount()=177 ge

Re: RFR: 8299234: JMX Repository.query performance

2023-01-10 Thread Daniel Fuchs
On Wed, 21 Dec 2022 18:50:52 GMT, Alexey Bakhtin wrote: > Please find a patch to improve JMX Repository.query performance > > Using ObjectName.apply() allows significantly decrease memory usage and the > number of GC cycles: > Before: > > $ java test 100 100 > Test PASSED in 8943169791

Re: RFR: 8299234: JMX Repository.query performance

2023-01-06 Thread Kevin Walls
On Wed, 21 Dec 2022 18:50:52 GMT, Alexey Bakhtin wrote: > Please find a patch to improve JMX Repository.query performance > > Using ObjectName.apply() allows significantly decrease memory usage and the > number of GC cycles: > Before: > > $ java test 100 100 > Test PASSED in 8943169791

RFR: 8299234: JMX Repository.query performance

2022-12-21 Thread Alexey Bakhtin
Please find a patch to improve JMX Repository.query performance Using ObjectName.apply() allows significantly decrease memory usage and the number of GC cycles: Before: $ java test 100 100 Test PASSED in 8943169791 ns. GC: G1 Young Generation getCollectionCount()=177 getCollectionTime()=