On Tue, 11 Apr 2023 21:47:40 GMT, Ashutosh Mehra wrote:
>> This PR combines the "open" and "closed" regions of the CDS archive heap
>> into a single region. This significantly simplifies the implementation,
>> making it more compatible with non-G1 collectors. There's a net removal of
>> ~1100
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src code and another ~1200 lines of tests.
>
> **Not
On Tue, 18 Apr 2023 20:16:06 GMT, Ioi Lam wrote:
>> This PR combines the "open" and "closed" regions of the CDS archive heap
>> into a single region. This significantly simplifies the implementation,
>> making it more compatible with non-G1 collectors. There's a net removal of
>> ~1000 lines i
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src code and another ~1200 lines of tests.
>
> **Not
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src code and another ~1200 lines of tests.
>
> **Not
On Wed, 12 Apr 2023 17:59:23 GMT, Ioi Lam wrote:
>> This PR combines the "open" and "closed" regions of the CDS archive heap
>> into a single region. This significantly simplifies the implementation,
>> making it more compatible with non-G1 collectors. There's a net removal of
>> ~1000 lines i
On Tue, 11 Apr 2023 21:47:40 GMT, Ashutosh Mehra wrote:
> cds changes look good! just few nitpicks.
Thanks for the review. I've incorporated your suggestions.
-
PR Comment: https://git.openjdk.org/jdk/pull/13284#issuecomment-1505698259
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src code and another ~1200 lines of tests.
>
> **Not
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src code and another ~1200 lines of tests.
>
> **Not
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src code and another ~1200 lines of tests.
>
> **Not
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src code and another ~1200 lines of tests.
>
> **Not
On Fri, 7 Apr 2023 19:17:46 GMT, Matias Saavedra Silva
wrote:
>> Ioi Lam has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - more clean up: heap_regions -> heap_region, etc
>> - @matias9927 comments
>
> src/hotspot/share/cds/archiveBuild
On Mon, 3 Apr 2023 03:32:27 GMT, Ioi Lam wrote:
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src
On Sat, 8 Apr 2023 07:14:30 GMT, Thomas Stuefe wrote:
> This looks like a nice simplification. Will you also combine all mappings at
> OS level to a single one, so that you only need one mmap call?
Now there's a single call to mmap() in
FileMapInfo::map_heap_regions_impl_inner(). This reminds
On Mon, 3 Apr 2023 03:32:27 GMT, Ioi Lam wrote:
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src
On Mon, 3 Apr 2023 03:32:27 GMT, Ioi Lam wrote:
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src
On Mon, 3 Apr 2023 03:32:27 GMT, Ioi Lam wrote:
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src
This PR combines the "open" and "closed" regions of the CDS archive heap into a
single region. This significantly simplifies the implementation, making it more
compatible with non-G1 collectors. There's a net removal of ~1000 lines in src
code and another ~1200 lines of tests.
**Notes for revie
18 matches
Mail list logo
