Re: RFR: 8296875: Generational ZGC: Refactor loom code [v4]

2022-11-28 Thread Patricio Chilano Mateo
On Mon, 21 Nov 2022 12:17:02 GMT, Patricio Chilano Mateo wrote: >> Erik Österlund has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix Richard comments > > I went through the changes and all looks good to me. Only minor comments. > > Th

Re: RFR: 8296875: Generational ZGC: Refactor loom code [v4]

2022-11-28 Thread Erik Österlund
On Mon, 21 Nov 2022 12:17:02 GMT, Patricio Chilano Mateo wrote: >> Erik Österlund has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix Richard comments > > I went through the changes and all looks good to me. Only minor comments. > > Th

Re: RFR: 8296875: Generational ZGC: Refactor loom code [v4]

2022-11-21 Thread Patricio Chilano Mateo
On Thu, 17 Nov 2022 09:24:04 GMT, Erik Österlund wrote: >> The current loom code makes some assumptions about GC that will not work >> with generational ZGC. We should make this code more GC agnostic, and >> provide a better interface for talking to the GC. >> >> In particular, >> 1) All GCs h

Re: RFR: 8296875: Generational ZGC: Refactor loom code [v4]

2022-11-17 Thread Erik Österlund
On Thu, 17 Nov 2022 11:23:07 GMT, Richard Reingruber wrote: >> Erik Österlund has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix Richard comments > > Marked as reviewed by rrich (Reviewer). Thanks for the review, @reinrich! --

Re: RFR: 8296875: Generational ZGC: Refactor loom code [v4]

2022-11-17 Thread Richard Reingruber
On Thu, 17 Nov 2022 09:24:04 GMT, Erik Österlund wrote: >> The current loom code makes some assumptions about GC that will not work >> with generational ZGC. We should make this code more GC agnostic, and >> provide a better interface for talking to the GC. >> >> In particular, >> 1) All GCs h

Re: RFR: 8296875: Generational ZGC: Refactor loom code [v4]

2022-11-17 Thread Erik Österlund
> The current loom code makes some assumptions about GC that will not work with > generational ZGC. We should make this code more GC agnostic, and provide a > better interface for talking to the GC. > > In particular, > 1) All GCs have a way of encoding oops inside of the heap differently to oop