Re: RFR: 8296445: C++ syntax error in jdwpTransport.h [v2]

2022-11-07 Thread Leonid Mesnik
On Tue, 8 Nov 2022 00:43:28 GMT, pandaapo wrote: >> Fix a syntax error in the code in jdwpTransport.h > > pandaapo has updated the pull request incrementally with one additional > commit since the last revision: > > Update the file header. Marked as reviewed by lmesnik (Reviewer). Marked as

Re: RFR: 8296445: C++ syntax error in jdwpTransport.h [v2]

2022-11-07 Thread pandaapo
> Fix a syntax error in the code in jdwpTransport.h pandaapo has updated the pull request incrementally with one additional commit since the last revision: Update the file header. - Changes: - all: https://git.openjdk.org/jdk/pull/11008/files - new: https://git.openjdk.org/jd

Re: RFR: 8296445: C++ syntax error in jdwpTransport.h

2022-11-07 Thread Leonid Mesnik
On Sun, 6 Nov 2022 23:02:35 GMT, pandaapo wrote: > Fix a syntax error in the code in jdwpTransport.h Sure, please update the copyright. - PR: https://git.openjdk.org/jdk/pull/11008

Re: RFR: 8296445: C++ syntax error in jdwpTransport.h

2022-11-07 Thread pandaapo
On Mon, 7 Nov 2022 20:48:09 GMT, Leonid Mesnik wrote: >> Fix a syntax error in the code in jdwpTransport.h > > Marked as reviewed by lmesnik (Reviewer). @lmesnik Thanks for your review. May I change `Copyright (c) 2003, 2017, Oracle and/or its affiliates.` to `Copyright (c) 2003, 2022, Oracle a

Re: RFR: 8296445: C++ syntax error in jdwpTransport.h

2022-11-07 Thread Serguei Spitsyn
On Sun, 6 Nov 2022 23:02:35 GMT, pandaapo wrote: > Fix a syntax error in the code in jdwpTransport.h Marked as reviewed by sspitsyn (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11008

Re: RFR: 8296445: C++ syntax error in jdwpTransport.h

2022-11-07 Thread Leonid Mesnik
On Sun, 6 Nov 2022 23:02:35 GMT, pandaapo wrote: > Fix a syntax error in the code in jdwpTransport.h Marked as reviewed by lmesnik (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11008

Re: RFR: 8296445: C++ syntax error in jdwpTransport.h

2022-11-07 Thread Alex Menkov
On Sun, 6 Nov 2022 23:02:35 GMT, pandaapo wrote: > Fix a syntax error in the code in jdwpTransport.h Need to update copyright year in the header - PR: https://git.openjdk.org/jdk/pull/11008

Re: RFR: 8296445: C++ syntax error in jdwpTransport.h

2022-11-07 Thread Chris Plummer
On Sun, 6 Nov 2022 23:02:35 GMT, pandaapo wrote: > Fix a syntax error in the code in jdwpTransport.h Change looks good. - Marked as reviewed by cjplummer (Reviewer). PR: https://git.openjdk.org/jdk/pull/11008

Re: RFR: 8296445: C++ syntax error in jdwpTransport.h

2022-11-06 Thread pandaapo
On Mon, 7 Nov 2022 01:33:53 GMT, Dingli Zhang wrote: > Hi @pandaapo thanks for your patch! You need to change the name of this PR to > `8296445: C++ syntax error in jdwpTransport.h` to match the issue in JBS. Thanks. @DingliZhang - PR: https://git.openjdk.org/jdk/pull/11008