Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v3]

2022-11-14 Thread Chris Plummer
On Thu, 10 Nov 2022 20:58:36 GMT, Chris Plummer wrote: >> The debug agent sets a breakpoint in Thread.resume() so it can prevent the >> debugger from suspending threads while in the resume call: >> >> /* >> * Track the resuming thread by marking it as being within >>

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v3]

2022-11-14 Thread Chris Plummer
On Fri, 11 Nov 2022 07:01:19 GMT, Alan Bateman wrote: > This is good cleanup, I had forgotten that the JDWP agent has code to defend > against direct use of Thread.resume. The changes look good. Somewhat > subjective, but I think I would have made the comment in commonSuspendByNode > just say

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v3]

2022-11-10 Thread Alan Bateman
On Thu, 10 Nov 2022 20:58:36 GMT, Chris Plummer wrote: >> The debug agent sets a breakpoint in Thread.resume() so it can prevent the >> debugger from suspending threads while in the resume call: >> >> /* >> * Track the resuming thread by marking it as being within >>

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v3]

2022-11-10 Thread Chris Plummer
> The debug agent sets a breakpoint in Thread.resume() so it can prevent the > debugger from suspending threads while in the resume call: > > /* > * Track the resuming thread by marking it as being within > * a resume and by setting up for notification on