Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v3]

2022-11-14 Thread Chris Plummer
On Thu, 10 Nov 2022 20:58:36 GMT, Chris Plummer wrote: >> The debug agent sets a breakpoint in Thread.resume() so it can prevent the >> debugger from suspending threads while in the resume call: >> >> /* >> * Track the resuming thread by marking it as being within >>

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v3]

2022-11-14 Thread Chris Plummer
On Fri, 11 Nov 2022 07:01:19 GMT, Alan Bateman wrote: > This is good cleanup, I had forgotten that the JDWP agent has code to defend > against direct use of Thread.resume. The changes look good. Somewhat > subjective, but I think I would have made the comment in commonSuspendByNode > just say

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v3]

2022-11-10 Thread Alan Bateman
On Thu, 10 Nov 2022 20:58:36 GMT, Chris Plummer wrote: >> The debug agent sets a breakpoint in Thread.resume() so it can prevent the >> debugger from suspending threads while in the resume call: >> >> /* >> * Track the resuming thread by marking it as being within >>

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v3]

2022-11-10 Thread Chris Plummer
> The debug agent sets a breakpoint in Thread.resume() so it can prevent the > debugger from suspending threads while in the resume call: > > /* > * Track the resuming thread by marking it as being within > * a resume and by setting up for notification on

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v2]

2022-11-10 Thread Chris Plummer
On Thu, 10 Nov 2022 11:03:25 GMT, Serguei Spitsyn wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Cleanup some suspect suspendOnStart and toBeResumed checks. > > src/jdk.jdwp.agent/share/native/libjdwp/threadContr

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v2]

2022-11-10 Thread Serguei Spitsyn
On Wed, 9 Nov 2022 05:57:32 GMT, Chris Plummer wrote: >> The debug agent sets a breakpoint in Thread.resume() so it can prevent the >> debugger from suspending threads while in the resume call: >> >> /* >> * Track the resuming thread by marking it as being within >>

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v2]

2022-11-10 Thread Serguei Spitsyn
On Wed, 9 Nov 2022 05:57:32 GMT, Chris Plummer wrote: >> The debug agent sets a breakpoint in Thread.resume() so it can prevent the >> debugger from suspending threads while in the resume call: >> >> /* >> * Track the resuming thread by marking it as being within >>

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v2]

2022-11-09 Thread Chris Plummer
On Wed, 9 Nov 2022 09:50:21 GMT, Serguei Spitsyn wrote: > I've started looking at this fix. > Wow, it is very big and nice cleanup! Fortunately it is pretty much entirely code deletion. The main exception is some cleanup of suspect suspendOnStart and toBeResumed checks. I'm guessing the were d

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v2]

2022-11-09 Thread Serguei Spitsyn
On Wed, 9 Nov 2022 05:57:32 GMT, Chris Plummer wrote: >> The debug agent sets a breakpoint in Thread.resume() so it can prevent the >> debugger from suspending threads while in the resume call: >> >> /* >> * Track the resuming thread by marking it as being within >>

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v2]

2022-11-08 Thread Chris Plummer
On Wed, 9 Nov 2022 05:57:32 GMT, Chris Plummer wrote: >> The debug agent sets a breakpoint in Thread.resume() so it can prevent the >> debugger from suspending threads while in the resume call: >> >> /* >> * Track the resuming thread by marking it as being within >>

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v2]

2022-11-08 Thread Chris Plummer
> The debug agent sets a breakpoint in Thread.resume() so it can prevent the > debugger from suspending threads while in the resume call: > > /* > * Track the resuming thread by marking it as being within > * a resume and by setting up for notification on

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume()

2022-11-03 Thread Chris Plummer
On Mon, 31 Oct 2022 19:08:14 GMT, Chris Plummer wrote: > The debug agent sets a breakpoint in Thread.resume() so it can prevent the > debugger from suspending threads while in the resume call: > > /* > * Track the resuming thread by marking it as being within >

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume()

2022-10-31 Thread Chris Plummer
On Mon, 31 Oct 2022 19:08:14 GMT, Chris Plummer wrote: > The debug agent sets a breakpoint in Thread.resume() so it can prevent the > debugger from suspending threads while in the resume call: > > /* > * Track the resuming thread by marking it as being within >

RFR: 8296089: Remove debug agent code for special handling of Thread.resume()

2022-10-31 Thread Chris Plummer
The debug agent sets a breakpoint in Thread.resume() so it can prevent the debugger from suspending threads while in the resume call: /* * Track the resuming thread by marking it as being within * a resume and by setting up for notification on