Re: RFR: 8295657: SA: Allow larger object alignments [v2]

2022-10-21 Thread Aleksey Shipilev
On Thu, 20 Oct 2022 09:40:55 GMT, Aleksey Shipilev wrote: >> Found this when working on JOL support >> ([CODETOOLS-7903364](https://bugs.openjdk.org/browse/CODETOOLS-7903364)). If >> you try to attach to VM running with -XX:ObjectAlignmentInBytes=32, then SA >> would fail with: >> >> >> Caus

Re: RFR: 8295657: SA: Allow larger object alignments [v2]

2022-10-20 Thread Chris Plummer
On Thu, 20 Oct 2022 09:40:55 GMT, Aleksey Shipilev wrote: >> Found this when working on JOL support >> ([CODETOOLS-7903364](https://bugs.openjdk.org/browse/CODETOOLS-7903364)). If >> you try to attach to VM running with -XX:ObjectAlignmentInBytes=32, then SA >> would fail with: >> >> >> Caus

Re: RFR: 8295657: SA: Allow larger object alignments [v2]

2022-10-20 Thread Aleksey Shipilev
On Wed, 19 Oct 2022 22:44:37 GMT, Chris Plummer wrote: >> Yes. I don't see a need for it. > > You could keep in the check to make sure it is aligned to a power of 2, since > I doubt SA would work with a value that isn't, but then I don't see the > possibility of hotspot ever supporting it eithe

Re: RFR: 8295657: SA: Allow larger object alignments [v2]

2022-10-20 Thread Aleksey Shipilev
> Found this when working on JOL support > ([CODETOOLS-7903364](https://bugs.openjdk.org/browse/CODETOOLS-7903364)). If > you try to attach to VM running with -XX:ObjectAlignmentInBytes=32, then SA > would fail with: > > > Caused by: java.lang.RuntimeException: Object alignment 32 not yet supp