Re: RFR: 8295253: Remove kludge from v1_0/PerfDataBuffer.java

2022-11-25 Thread Ioi Lam
On Wed, 23 Nov 2022 19:42:47 GMT, Serguei Spitsyn wrote: >> Remove code for supporting an ancient JDK version (1.4.2). We don't have any >> test cases for this code so it's unclear whether it still works or not. >> >> Testing: tiers 1-4. > > Looks good and reasonable. > Thanks, > Serguei Thank

Re: RFR: 8295253: Remove kludge from v1_0/PerfDataBuffer.java

2022-11-23 Thread Chris Plummer
On Wed, 23 Nov 2022 18:25:59 GMT, Ioi Lam wrote: > Remove code for supporting an ancient JDK version (1.4.2). We don't have any > test cases for this code so it's unclear whether it still works or not. > > Testing: tiers 1-4. Looks good. Thanks for the cleanup! - Marked as review

Re: RFR: 8295253: Remove kludge from v1_0/PerfDataBuffer.java

2022-11-23 Thread David Holmes
On Wed, 23 Nov 2022 18:25:59 GMT, Ioi Lam wrote: > Remove code for supporting an ancient JDK version (1.4.2). We don't have any > test cases for this code so it's unclear whether it still works or not. > > Testing: tiers 1-4. Looks good. Surprised that code survived for so long! Thanks. ---

Re: RFR: 8295253: Remove kludge from v1_0/PerfDataBuffer.java

2022-11-23 Thread Serguei Spitsyn
On Wed, 23 Nov 2022 18:25:59 GMT, Ioi Lam wrote: > Remove code for supporting an ancient JDK version (1.4.2). We don't have any > test cases for this code so it's unclear whether it still works or not. > > Testing: tiers 1-4. Looks good and reasonable. Thanks, Serguei - Marked as

RFR: 8295253: Remove kludge from v1_0/PerfDataBuffer.java

2022-11-23 Thread Ioi Lam
Remove code for supporting an ancient JDK version (1.4.2). We don't have any test cases for this code so it's unclear whether it still works or not. Testing: tiers 1-4. - Commit messages: - 8295253: Remove kludge from v1_0/PerfDataBuffer.java Changes: https://git.openjdk.org/jdk/p