Re: RFR: 8293325: Minor improvements to macos catch_mach_exception_raise() error handling

2022-09-03 Thread Chris Plummer
On Fri, 2 Sep 2022 18:49:27 GMT, Chris Plummer wrote: > While trying to find a fix for > [JDK-8288429](https://bugs.openjdk.org/browse/JDK-8288429) (no fix was > found), I made some adjustments to the error handling in > catch_mach_exception_raise() to make it a bit easier to understand the co

Re: RFR: 8293325: Minor improvements to macos catch_mach_exception_raise() error handling

2022-09-02 Thread Serguei Spitsyn
On Fri, 2 Sep 2022 18:49:27 GMT, Chris Plummer wrote: > While trying to find a fix for > [JDK-8288429](https://bugs.openjdk.org/browse/JDK-8288429) (no fix was > found), I made some adjustments to the error handling in > catch_mach_exception_raise() to make it a bit easier to understand the co

Re: RFR: 8293325: Minor improvements to macos catch_mach_exception_raise() error handling

2022-09-02 Thread Daniel D . Daugherty
On Fri, 2 Sep 2022 18:49:27 GMT, Chris Plummer wrote: > While trying to find a fix for > [JDK-8288429](https://bugs.openjdk.org/browse/JDK-8288429) (no fix was > found), I made some adjustments to the error handling in > catch_mach_exception_raise() to make it a bit easier to understand the co

Re: RFR: 8293325: Minor improvements to macos catch_mach_exception_raise() error handling

2022-09-02 Thread Chris Plummer
On Fri, 2 Sep 2022 19:37:16 GMT, Daniel D. Daugherty wrote: > Forgot to ask: what kind of testing has been done? I ran test/jdk/sun/tools/jhsdb about 300 times, basically enough times to at least reproduce the SIGILL failure once. I don't seem to see the SIGTRAP failure anymore. ERROR: catch

Re: RFR: 8293325: Minor improvements to macos catch_mach_exception_raise() error handling

2022-09-02 Thread Daniel D . Daugherty
On Fri, 2 Sep 2022 18:49:27 GMT, Chris Plummer wrote: > While trying to find a fix for > [JDK-8288429](https://bugs.openjdk.org/browse/JDK-8288429) (no fix was > found), I made some adjustments to the error handling in > catch_mach_exception_raise() to make it a bit easier to understand the co

Re: RFR: 8293325: Minor improvements to macos catch_mach_exception_raise() error handling

2022-09-02 Thread Alex Menkov
On Fri, 2 Sep 2022 18:49:27 GMT, Chris Plummer wrote: > While trying to find a fix for > [JDK-8288429](https://bugs.openjdk.org/browse/JDK-8288429) (no fix was > found), I made some adjustments to the error handling in > catch_mach_exception_raise() to make it a bit easier to understand the co

RFR: 8293325: Minor improvements to macos catch_mach_exception_raise() error handling

2022-09-02 Thread Chris Plummer
While trying to find a fix for [JDK-8288429](https://bugs.openjdk.org/browse/JDK-8288429) (no fix was found), I made some adjustments to the error handling in catch_mach_exception_raise() to make it a bit easier to understand the code, and to provide a more meaningful error message when the sof